Skip to content

Commit d5e02a2

Browse files
committed
Contain dismissal logic to view model only
1 parent f294478 commit d5e02a2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

WooCommerce/Classes/ViewRelated/Orders/OrderListViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ private extension OrderListViewController {
797797
let shareIPPFeedbackAction = TopBannerViewModel.ActionButton(title: Localization.shareFeedbackButton, action: { [weak self] _ in
798798
self?.displayIPPFeedbackBannerSurvey()
799799
// We dismiss the banner at this point as we cannot know if the user successfully submitted it
800-
self?.viewModel.dismissIPPFeedbackBanner(remindAfterDays: nil)
800+
self?.viewModel.IPPFeedbackWasDismissed()
801801
})
802802

803803
let viewModel = TopBannerViewModel(

WooCommerce/Classes/ViewRelated/Orders/OrderListViewModel.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,10 @@ extension OrderListViewModel {
377377
func dontShowAgainTapped() {
378378
dismissIPPFeedbackBanner(remindAfterDays: nil)
379379
}
380+
381+
func IPPFeedbackWasDismissed() {
382+
dismissIPPFeedbackBanner(remindAfterDays: nil)
383+
}
380384
}
381385

382386
// MARK: - Remote Notifications Observation

0 commit comments

Comments
 (0)