Merge branch 'woomob-870-shipping-labels-validate-dimensions-for-custom-packages' into woomob-874-shipping-labels-third-checkbox-on-ups-popup-is-not-visible

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooShippingAddCustomPackageViewModel.swift

@@ -67,7 +67,7 @@ final class WooShippingAddCustomPackageViewModel: ObservableObject {
         for (key, value) in fieldValues {
             guard keysToCheck.contains(key) else { continue }
             let doubleValue = Double(value)
-            if doubleValue == nil || doubleValue == 0 {
+            guard let doubleValue, doubleValue > 0 else {
                 return false
             }
         }

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/WooShipping Create Shipping Labels/WooShippingAddCustomPackageViewModelTests.swift

@@ -281,31 +281,6 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
 
     // MARK: - allDimensionsValid tests
 
-    func test_allDimensionsValid_returns_false_when_no_dimensions_set() {
-        // Given
-        let siteID: Int64 = 1234
-        let mockStores = MockStoresManager(sessionManager: .testingInstance)
-        let viewModel = WooShippingAddCustomPackageViewModel(siteID: siteID, stores: mockStores)
-
-        // Then
-        XCTAssertFalse(viewModel.allDimensionsValid)
-    }
-
-    func test_allDimensionsValid_returns_false_when_some_dimensions_missing() {
-        // Given
-        let siteID: Int64 = 1234
-        let mockStores = MockStoresManager(sessionManager: .testingInstance)
-        let viewModel = WooShippingAddCustomPackageViewModel(siteID: siteID, stores: mockStores)
-
-        // When
-        viewModel.fieldValues[.length] = "10"
-        viewModel.fieldValues[.width] = "5"
-        // height is missing
-
-        // Then
-        XCTAssertFalse(viewModel.allDimensionsValid)
-    }
-
     func test_allDimensionsValid_returns_false_when_dimension_is_zero() {
         // Given
         let siteID: Int64 = 1234