Merge pull request #9889 from woocommerce/update-login-flow-return-value

jostnes · web-flow · commit d66b3fa8a7e6 · 2023-06-07T20:56:48.000+08:00
[UI Test] - Remove redundant return value
diff --git a/WooCommerce/WooCommerceUITests/Flows/LoginFlow.swift b/WooCommerce/WooCommerceUITests/Flows/LoginFlow.swift
@@ -25,11 +25,10 @@ class LoginFlow {
 
     @discardableResult
     static func logInWithSiteAddress() throws -> MyStoreScreen {
-        try PrologueScreen()
+        return try PrologueScreen()
             .tapLogIn()
             .proceedWith(siteUrl: TestCredentials.siteUrl)
             .proceedWith(email: TestCredentials.emailAddress)
             .enterValidPassword()
-        return try MyStoreScreen()
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,10 @@ class LoginFlow {`
`25`	`25`
`26`	`26`	`@discardableResult`
`27`	`27`	`static func logInWithSiteAddress() throws -> MyStoreScreen {`
`28`		`- try PrologueScreen()`
	`28`	`+ return try PrologueScreen()`
`29`	`29`	`.tapLogIn()`
`30`	`30`	`.proceedWith(siteUrl: TestCredentials.siteUrl)`
`31`	`31`	`.proceedWith(email: TestCredentials.emailAddress)`
`32`	`32`	`.enterValidPassword()`
`33`		`- return try MyStoreScreen()`
`34`	`33`	`}`
`35`	`34`	`}`