Skip to content

Commit d968d88

Browse files
committed
Replace local feature flag check for liquid glass design enabled state with Info.plist check.
1 parent c743243 commit d968d88

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

Modules/Sources/Experiments/DefaultFeatureFlagService.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
9898
return buildConfig == .localDeveloper || buildConfig == .alpha
9999
case .ciabBookings:
100100
return buildConfig == .localDeveloper || buildConfig == .alpha
101-
case .liquidGlassDesign:
102-
return buildConfig == .localDeveloper || buildConfig == .alpha
103101
case .pointOfSaleSurveys:
104102
return buildConfig == .localDeveloper || buildConfig == .alpha
105103
default:

Modules/Sources/Experiments/FeatureFlag.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,6 @@ public enum FeatureFlag: Int {
204204
///
205205
case ciabBookings
206206

207-
/// Should be enabled when the Liquid Glass design is enabled (via the Info.plist `UIDesignRequiresCompatibility`).
208-
/// Current changes behind this feature flag: replacing the Menu tab custom "dot" badge with the native tab bar badge.
209-
///
210-
case liquidGlassDesign
211-
212207
/// Enables surveys for potential and current POS merchants
213208
///
214209
case pointOfSaleSurveys

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,8 +929,9 @@ private extension MainTabBarController {
929929
func updateMenuTabBadge(with action: NotificationBadgeActionType) {
930930
let tab = WooTab.hubMenu
931931
let tabIndex = tab.visibleIndex(isPOSTabVisible: isPOSTabVisible, isBookingsTabVisible: isBookingsTabVisible)
932+
let isLiquidGlassDesignDisabled = Bundle.main.infoDictionary?["UIDesignRequiresCompatibility"] as? Bool ?? false
932933

933-
guard featureFlagService.isFeatureFlagEnabled(.liquidGlassDesign) else {
934+
guard !isLiquidGlassDesignDisabled else {
934935
let input = NotificationsBadgeInput(action: action, tab: tab, tabBar: tabBar, tabIndex: tabIndex)
935936
notificationsBadge.updateBadge(with: input)
936937
return

0 commit comments

Comments
 (0)