Skip to content

Commit dad2691

Browse files
committed
Merge branch 'trunk' into issue/7944-product-preview-flow
# Conflicts: # Experiments/Experiments/FeatureFlag.swift # WooCommerce/WooCommerceTests/Mocks/MockFeatureFlagService.swift
2 parents d69489c + 10098bb commit dad2691

File tree

64 files changed

+844
-190
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+844
-190
lines changed

Experiments/Experiments/ABTest.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ public enum ABTest: String, CaseIterable {
1414

1515
/// A/A test to make sure there is no bias in the logged out state.
1616
/// Experiment ref: pbxNRc-1S0-p2
17-
case aaTestLoggedOut202209 = "woocommerceios_explat_aa_test_logged_out_202209"
18-
19-
/// A/B test for the login button order on the prologues screen.
20-
/// Experiment ref: pbxNRc-1VA-p2
21-
case loginPrologueButtonOrder = "woocommerceios_login_prologue_button_order_202209"
17+
case aaTestLoggedOut = "woocommerceios_explat_aa_test_logged_out_202211"
2218

2319
/// Returns a variation for the given experiment
2420
public var variation: Variation {
@@ -32,7 +28,7 @@ public enum ABTest: String, CaseIterable {
3228
switch self {
3329
case .aaTestLoggedIn202210:
3430
return .loggedIn
35-
case .aaTestLoggedOut202209, .loginPrologueButtonOrder:
31+
case .aaTestLoggedOut:
3632
return .loggedOut
3733
case .null:
3834
return .none

Experiments/Experiments/DefaultFeatureFlagService.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
4545
return buildConfig == .localDeveloper || buildConfig == .alpha
4646
case .storeCreationMVP:
4747
return buildConfig == .localDeveloper || buildConfig == .alpha
48-
case .productsOnboarding:
49-
return buildConfig == .localDeveloper || buildConfig == .alpha
5048
case .simplifiedLoginFlowI1:
5149
return buildConfig == .localDeveloper || buildConfig == .alpha
50+
case .justInTimeMessagesOnDashboard:
51+
return buildConfig == .localDeveloper || buildConfig == .alpha
52+
case .productsOnboarding:
53+
return buildConfig == .localDeveloper || buildConfig == .alpha
5254
default:
5355
return true
5456
}

Experiments/Experiments/FeatureFlag.swift

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,16 @@ public enum FeatureFlag: Int {
8686
///
8787
case storeCreationMVP
8888

89-
/// Hides products onboarding development.
90-
///
91-
case productsOnboarding
92-
9389
/// Temporary feature flag for the simplified login flow.
9490
/// TODO: replace with A/B testing.
9591
///
9692
case simplifiedLoginFlowI1
93+
94+
/// Just In Time Messages on Dashboard
95+
///
96+
case justInTimeMessagesOnDashboard
97+
98+
/// Hides products onboarding development.
99+
///
100+
case productsOnboarding
97101
}

Networking/Networking/Model/JustInTimeMessage.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Codegen
33

44
/// Just In Time Message
55
/// Also referred to as JITM, these messages are triggered on a per WPcom user basis, and can be requested for particular contexts within the app.
6-
/// They are generally displayed as a title, description, and CTA button
6+
/// They are generally displayed as a title, description, and Call To Action (CTA) button
77
///
88
public struct JustInTimeMessage: GeneratedCopiable, GeneratedFakeable, Equatable {
99
/// Site Identifier
@@ -18,15 +18,15 @@ public struct JustInTimeMessage: GeneratedCopiable, GeneratedFakeable, Equatable
1818
///
1919
public let featureClass: String
2020

21-
/// Validity of the JITM in seconds
21+
/// TTL, or Time To Live: validity of the JITM's client-side dismissal in seconds, only relevant after dismissal.
2222
///
2323
public let ttl: Int64
2424

2525
/// Content of the JITM: in particular, the title and description of the message
2626
///
2727
public let content: Content
2828

29-
/// The Call to Action for the JITM: in particular, the button text and link to open
29+
/// CTA, or Call to Action: button details for the JITM: in particular, the button text and link to open
3030
///
3131
public let cta: CTA
3232

Podfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ target 'WooCommerce' do
6565
pod 'Gridicons', '~> 1.2.0'
6666

6767
# To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1
68-
pod 'WordPressAuthenticator', '~> 3.2.0'
69-
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => ''
68+
pod 'WordPressAuthenticator', '~> 3.3.0-beta.2'
69+
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => ''
7070
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :branch => ''
7171
# pod 'WordPressAuthenticator', :path => '../WordPressAuthenticator-iOS'
7272

Podfile.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ PODS:
4242
- WordPress-Aztec-iOS (1.11.0)
4343
- WordPress-Editor-iOS (1.11.0):
4444
- WordPress-Aztec-iOS (= 1.11.0)
45-
- WordPressAuthenticator (3.2.0):
46-
- Alamofire (~> 4.8)
45+
- WordPressAuthenticator (3.3.0-beta.2):
4746
- CocoaLumberjack (~> 3.5)
4847
- GoogleSignIn (~> 6.0.1)
4948
- Gridicons (~> 1.0)
@@ -92,7 +91,7 @@ DEPENDENCIES:
9291
- Sourcery (~> 1.0.3)
9392
- StripeTerminal (~> 2.7)
9493
- WordPress-Editor-iOS (~> 1.11.0)
95-
- WordPressAuthenticator (~> 3.2.0)
94+
- WordPressAuthenticator (~> 3.3.0-beta.2)
9695
- WordPressKit (~> 4.49.0)
9796
- WordPressShared (~> 1.15)
9897
- WordPressUI (~> 1.12.5)
@@ -102,6 +101,8 @@ DEPENDENCIES:
102101
- ZendeskSupportSDK (~> 5.0)
103102

104103
SPEC REPOS:
104+
https://github.com/wordpress-mobile/cocoapods-specs.git:
105+
- WordPressAuthenticator
105106
trunk:
106107
- Alamofire
107108
- AppAuth
@@ -124,7 +125,6 @@ SPEC REPOS:
124125
- UIDeviceIdentifier
125126
- WordPress-Aztec-iOS
126127
- WordPress-Editor-iOS
127-
- WordPressAuthenticator
128128
- WordPressKit
129129
- WordPressShared
130130
- WordPressUI
@@ -162,7 +162,7 @@ SPEC CHECKSUMS:
162162
UIDeviceIdentifier: af4e11e25a2ea670078e2bd677bb0e8144f9f063
163163
WordPress-Aztec-iOS: 050b34d4c3adfb7c60363849049b13d60683b348
164164
WordPress-Editor-iOS: 304098424f1051cb271546c99f906aac296b1b81
165-
WordPressAuthenticator: ee31d9b0420d2ab7a98e7fe931d3333bf97a47b2
165+
WordPressAuthenticator: cafaace4519c72caef6bf950204bf21380194894
166166
WordPressKit: 96deb6ba37ea5eaec4ddcaa53eca04d653246152
167167
WordPressShared: 5477f179c7fe03b5d574f91adda66f67d131827e
168168
WordPressUI: c5be816f6c7b3392224ac21de9e521e89fa108ac
@@ -178,6 +178,6 @@ SPEC CHECKSUMS:
178178
ZendeskSupportProvidersSDK: 2bdf8544f7cd0fd4c002546f5704b813845beb2a
179179
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba
180180

181-
PODFILE CHECKSUM: 2824ed96b744a10c5fd0ac69b7e99ae9e1cdeb7d
181+
PODFILE CHECKSUM: 0f7a7c8c049a0c2ca072d18e289ac2889027a4f7
182182

183183
COCOAPODS: 1.11.3

WooCommerce/Classes/Analytics/WooAnalyticsEvent.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,7 @@ extension WooAnalyticsEvent {
579579
case paymentMethods = "payment_methods"
580580
case productDetail = "product_detail"
581581
case settings
582+
case myStore = "my_store"
582583
}
583584

584585
/// Keys for the Feature Card properties

WooCommerce/Classes/AppDelegate.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,7 @@ private extension AppDelegate {
405405
if versionOfLastRun == nil {
406406
// First run after a fresh install
407407
ServiceLocator.analytics.track(.applicationInstalled,
408-
withProperties: ["after_abtest_setup": true,
409-
"prologue_experiment_variant": ABTest.loginPrologueButtonOrder.variation.analyticsValue])
408+
withProperties: ["after_abtest_setup": true])
410409
} else if versionOfLastRun != currentVersion {
411410
// App was upgraded
412411
ServiceLocator.analytics.track(.applicationUpgraded, withProperties: ["previous_version": versionOfLastRun ?? String()])

WooCommerce/Classes/Authentication/AuthenticationConstants.swift

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@ struct AuthenticationConstants {
2525
comment: "Sign in instructions on the 'log in using WordPress.com account' screen."
2626
)
2727

28+
/// Get started instructions when simplified login is enabled.
29+
///
30+
static let getStartedInstructionsForSimplifiedLogin = NSLocalizedString(
31+
"Enter your email address to get started.",
32+
comment: "Sign in instructions on the 'log in using WordPress.com account' screen."
33+
)
34+
2835
/// What is WordPress.com? link (Continue with WordPress.com)
2936
///
3037
static let whatIsWPComLinkTitle = NSLocalizedString(
@@ -58,6 +65,13 @@ struct AuthenticationConstants {
5865
comment: "Sign in instructions asking user to enter WordPress.com password to proceed with sign in using Apple process"
5966
)
6067

68+
/// Simplified Log In button
69+
///
70+
static let loginButtonTitle = NSLocalizedString(
71+
"Log In",
72+
comment: "Button title in the simplified login prologue screen. Takes the user to the login flow."
73+
)
74+
6175
/// Title of "Continue With WordPress.com" button in Login Prologue
6276
//
6377
static let continueWithWPButtonTitle = NSLocalizedString(
@@ -106,4 +120,18 @@ struct AuthenticationConstants {
106120
"If you continue with Apple and don't already have a WordPress.com account, you are creating an account and you agree to our _Terms of Service_.",
107121
comment: "Legal disclaimer for signing up. The underscores _..._ denote underline."
108122
)
123+
124+
/// Create a Store button in Simplified login flow
125+
///
126+
static let createSiteButtonTitle = NSLocalizedString(
127+
"Create a Store",
128+
comment: "Button displayed on the prologue screen of the simplified login flow to create a new store"
129+
)
130+
131+
/// Instructions for WPCom password
132+
///
133+
static let wpcomPasswordInstructions = NSLocalizedString(
134+
"Enter the password for your account.",
135+
comment: "Instructional text shown when requesting the user's password for WPCom login."
136+
)
109137
}

0 commit comments

Comments
 (0)