Remove hardcoded mention of today time interval

Author: ealeksandrov

WooCommerce/StoreWidgets/Homescreen/StoreInfoView.swift

@@ -225,7 +225,7 @@ private extension StoreInfoView {
         static let viewMore = AppLocalizedString(
             "storeWidgets.infoView.viewMore",
             value: "View More",
-            comment: "Title for the button indicator to display more stats in the Today's Stat widget when using accessibility fonts."
+            comment: "Title for the button indicator to display more stats in the Stat widget when using accessibility fonts."
         )
         static func updatedAt(_ updatedTime: String) -> LocalizedString {
             let format = AppLocalizedString("storeWidgets.infoView.updatedAt",
@@ -247,7 +247,7 @@ private extension NotLoggedInView {
     enum Localization {
         static let notLoggedIn = AppLocalizedString(
             "storeWidgets.notLoggedInView.notLoggedIn",
-            value: "Log in to see today’s stats.",
+            value: "Log in to see store’s stats.",
             comment: "Title label when the widget does not have a logged-in store."
         )
         static let login = AppLocalizedString(
@@ -269,7 +269,7 @@ private extension UnableToFetchView {
     enum Localization {
         static let unableToFetch = AppLocalizedString(
             "storeWidgets.unableToFetchView.unableToFetch",
-            value: "Unable to fetch today's stats",
+            value: "Unable to fetch store's stats",
             comment: "Title label when the widget can't fetch data."
         )
     }

WooCommerce/StoreWidgets/StoreInfoDataService.swift

@@ -1,6 +1,6 @@
 import Networking
 
-/// Orchestrator class that fetches today store stats data.
+/// Orchestrator class that fetches store stats data.
 ///
 final class StoreInfoDataService {
 
@@ -56,7 +56,7 @@ final class StoreInfoDataService {
 ///
 private extension StoreInfoDataService {
 
-    /// Async wrapper that fetches todays revenues & orders.
+    /// Async wrapper that fetches revenues & orders.
     ///
     func fetchRevenueAndOrders(for storeID: Int64, timeRange: StatsTimeRange) async throws -> OrderStatsV4 {
         try await withCheckedThrowingContinuation { continuation in

WooCommerce/StoreWidgets/StoreInfoProvider.swift

@@ -90,14 +90,14 @@ final class StoreInfoProvider: IntentTimelineProvider {
         networkService = strongService
         Task {
             do {
-                let todayStats = try await strongService.fetchStats(for: dependencies.storeID, timeRange: StatsTimeRange(configuration.timeRange))
-                let entry = Self.dataEntry(for: todayStats, with: dependencies)
+                let stats = try await strongService.fetchStats(for: dependencies.storeID, timeRange: StatsTimeRange(configuration.timeRange))
+                let entry = Self.dataEntry(for: stats, with: dependencies)
                 let reloadDate = Date(timeIntervalSinceNow: reloadInterval)
                 let timeline = Timeline<StoreInfoEntry>(entries: [entry], policy: .after(reloadDate))
                 completion(timeline)
             } catch {
                 // WooFoundation does not expose `DDLOG` types. Should we include them?
-                print("⛔️ Error fetching today's widget stats: \(error)")
+                print("⛔️ Error fetching widget stats: \(error)")
 
                 let reloadDate = Date(timeIntervalSinceNow: reloadInterval)
                 let timeline = Timeline<StoreInfoEntry>(entries: [.error], policy: .after(reloadDate))
@@ -155,14 +155,14 @@ private extension StoreInfoProvider {
 
     /// Real data entry.
     ///
-    static func dataEntry(for todayStats: StoreInfoDataService.Stats, with dependencies: Dependencies) -> StoreInfoEntry {
-        StoreInfoEntry.data(.init(range: Localization.periodString(from: todayStats.timeRange),
+    static func dataEntry(for stats: StoreInfoDataService.Stats, with dependencies: Dependencies) -> StoreInfoEntry {
+        StoreInfoEntry.data(.init(range: Localization.periodString(from: stats.timeRange),
                                   name: dependencies.storeName,
-                                  revenue: Self.formattedAmountString(for: todayStats.revenue, with: dependencies.storeCurrencySettings),
-                                  revenueCompact: Self.formattedAmountCompactString(for: todayStats.revenue, with: dependencies.storeCurrencySettings),
-                                  visitors: "\(todayStats.totalVisitors)",
-                                  orders: "\(todayStats.totalOrders)",
-                                  conversion: Self.formattedConversionString(for: todayStats.conversion),
+                                  revenue: Self.formattedAmountString(for: stats.revenue, with: dependencies.storeCurrencySettings),
+                                  revenueCompact: Self.formattedAmountCompactString(for: stats.revenue, with: dependencies.storeCurrencySettings),
+                                  visitors: "\(stats.totalVisitors)",
+                                  orders: "\(stats.totalOrders)",
+                                  conversion: Self.formattedConversionString(for: stats.conversion),
                                   updatedTime: Self.currentFormattedTime()))
     }
 
@@ -211,25 +211,25 @@ private extension StoreInfoProvider {
             switch timeRange {
             case .today:
                 return AppLocalizedString(
-                    "storeWidgets.infoProvider.today",
+                    "storeWidgets.timeRange.today",
                     value: "Today",
                     comment: "Range title for the store info widget"
                 )
             case .thisWeek:
                 return AppLocalizedString(
-                    "storeWidgets.infoProvider.thisWeek",
+                    "storeWidgets.timeRange.thisWeek",
                     value: "This Week",
                     comment: "Range title for the store info widget"
                 )
             case .thisMonth:
                 return AppLocalizedString(
-                    "storeWidgets.infoProvider.thisMonth",
+                    "storeWidgets.timeRange.thisMonth",
                     value: "This Month",
                     comment: "Range title for the store info widget"
                 )
             case .thisYear:
                 return AppLocalizedString(
-                    "storeWidgets.infoProvider.thisYear",
+                    "storeWidgets.timeRange.thisYear",
                     value: "This Year",
                     comment: "Range title for the store info widget"
                 )

WooCommerce/StoreWidgets/StoreInfoWidget.swift

@@ -61,12 +61,12 @@ private extension StoreInfoWidget {
     enum Localization {
         static let title = AppLocalizedString(
             "storeWidgets.displayName",
-            value: "Today",
+            value: "Stats",
             comment: "Widget title, displayed when selecting which widget to add"
         )
         static let description = AppLocalizedString(
             "storeWidgets.description",
-            value: "WooCommerce Stats Today",
+            value: "WooCommerce Stats",
             comment: "Widget description, displayed when selecting which widget to add"
         )
     }