Rename CreateCartError.noMatchingProduct to CreateCartError.productNotInCart to match the scenario more.

Author: jaclync

Networking/Networking/Remote/PaymentRemote.swift

@@ -44,7 +44,7 @@ public class PaymentRemote: Remote, PaymentRemoteProtocol {
         let request = DotcomRequest(wordpressApiVersion: .mark1_1, method: .post, path: path, parameters: parameters)
         let response: CreateCartResponse = try await enqueue(request)
         guard response.products.contains(where: { $0.productID == productID }) else {
-            throw CreateCartError.noMatchingProduct
+            throw CreateCartError.productNotInCart
         }
     }
 }
@@ -69,7 +69,7 @@ public enum LoadPlanError: Error {
 
 /// Possible error cases from creating cart for a site with a WPCOM plan.
 public enum CreateCartError: Error {
-    case noMatchingProduct
+    case productNotInCart
 }
 
 /// Contains necessary data for handling the remote response from creating a cart.

Networking/NetworkingTests/Remote/PaymentRemoteTests.swift

@@ -76,7 +76,7 @@ final class PaymentRemoteTests: XCTestCase {
         }
     }
 
-    func test_createCart_throws_noMatchingProduct_error_when_response_does_not_include_plan_with_given_id() async throws {
+    func test_createCart_throws_productNotInCart_error_when_response_does_not_include_plan_with_given_id() async throws {
         // Given
         let siteID: Int64 = 606
         let remote = PaymentRemote(network: network)
@@ -87,7 +87,7 @@ final class PaymentRemoteTests: XCTestCase {
             _ = try await remote.createCart(siteID: siteID, productID: 685)
         } errorAssert: { error in
             // Then
-            (error as? CreateCartError) == .noMatchingProduct
+            (error as? CreateCartError) == .productNotInCart
         }
     }