Added unit tests for SiteSettingsRemote

Author: bummytime

Networking/Networking.xcodeproj/project.pbxproj

@@ -61,6 +61,7 @@
 		74CF5E8421402C04000CED0A /* TopEarnerStatsRemoteTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74CF5E8321402C04000CED0A /* TopEarnerStatsRemoteTests.swift */; };
 		74D3BD142114FE6900A6E85E /* MIContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74D3BD132114FE6900A6E85E /* MIContainer.swift */; };
 		74D522B62113607F00042831 /* StatGranularity.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74D522B52113607F00042831 /* StatGranularity.swift */; };
+		74D5BECE217E0F98007B0348 /* SiteSettingsRemoteTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74D5BECD217E0F98007B0348 /* SiteSettingsRemoteTests.swift */; };
 		74E30951216E8DCE00ABCE4C /* site-visits-alt.json in Resources */ = {isa = PBXBuildFile; fileRef = 74E30950216E8DCE00ABCE4C /* site-visits-alt.json */; };
 		B505F6CD20BEE37E00BB1B69 /* AccountMapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = B505F6CC20BEE37E00BB1B69 /* AccountMapper.swift */; };
 		B505F6CF20BEE38B00BB1B69 /* Account.swift in Sources */ = {isa = PBXBuildFile; fileRef = B505F6CE20BEE38B00BB1B69 /* Account.swift */; };
@@ -179,6 +180,7 @@
 		74CF5E8321402C04000CED0A /* TopEarnerStatsRemoteTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TopEarnerStatsRemoteTests.swift; sourceTree = "<group>"; };
 		74D3BD132114FE6900A6E85E /* MIContainer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MIContainer.swift; sourceTree = "<group>"; };
 		74D522B52113607F00042831 /* StatGranularity.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StatGranularity.swift; sourceTree = "<group>"; };
+		74D5BECD217E0F98007B0348 /* SiteSettingsRemoteTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SiteSettingsRemoteTests.swift; sourceTree = "<group>"; };
 		74E30950216E8DCE00ABCE4C /* site-visits-alt.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "site-visits-alt.json"; sourceTree = "<group>"; };
 		753D6504FF01F09F6A33B73E /* Pods-Networking.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Networking.debug.xcconfig"; path = "../Pods/Target Support Files/Pods-Networking/Pods-Networking.debug.xcconfig"; sourceTree = "<group>"; };
 		B505F6CC20BEE37E00BB1B69 /* AccountMapper.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AccountMapper.swift; sourceTree = "<group>"; };
@@ -316,6 +318,7 @@
 				B505F6D620BEE58800BB1B69 /* AccountRemoteTests.swift */,
 				B518662920A09C6F00037A38 /* OrdersRemoteTests.swift */,
 				74AE244C2113704C00CA8C54 /* OrderStatsRemoteTests.swift */,
+				74D5BECD217E0F98007B0348 /* SiteSettingsRemoteTests.swift */,
 				74002D6B2118B88200A63C19 /* SiteVisitStatsRemoteTests.swift */,
 				74CF5E8321402C04000CED0A /* TopEarnerStatsRemoteTests.swift */,
 			);
@@ -813,6 +816,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				74CF5E8421402C04000CED0A /* TopEarnerStatsRemoteTests.swift in Sources */,
+				74D5BECE217E0F98007B0348 /* SiteSettingsRemoteTests.swift in Sources */,
 				74A7B4BC217A807400E85A8B /* SiteSettingsMapperTests.swift in Sources */,
 				74AE244D2113704C00CA8C54 /* OrderStatsRemoteTests.swift in Sources */,
 				B505F6D320BEE3A500BB1B69 /* AccountMapperTests.swift in Sources */,

Networking/Networking/Model/SiteSetting.swift

@@ -38,6 +38,8 @@ public struct SiteSetting: Decodable {
         var value = ""
         if let stringValue = try? container.decode(String.self, forKey: .value) {
             value = stringValue
+        } else {
+            DDLogWarn("⚠️ Could not successfully decode SiteSetting value for \(settingID)")
         }
 
         self.init(siteID: siteID, settingID: settingID, label: label, description: settingDescription, value: value) // initialize the struct

Networking/Networking/Remote/SiteSettingsRemote.swift

@@ -6,7 +6,7 @@ import Alamofire
 ///
 public class SiteSettingsRemote: Remote {
 
-    /// Retrieves all of the gneral `SiteSetting`s for a given site.
+    /// Retrieves all of the general `SiteSetting`s for a given site.
     ///
     /// - Parameters:
     ///   - siteID: Site for which we'll fetch the general settings.

Networking/NetworkingTests/Remote/SiteSettingsRemoteTests.swift

@@ -0,0 +1,54 @@
+import XCTest
+@testable import Networking
+
+
+/// SiteSettingsRemote Unit Tests
+///
+class SiteSettingsRemoteTests: XCTestCase {
+
+    /// Dummy Network Wrapper
+    ///
+    let network = MockupNetwork()
+
+    /// Dummy Site ID
+    ///
+    let sampleSiteID = 1234
+
+    /// Repeat always!
+    ///
+    override func setUp() {
+        network.removeAllSimulatedResponses()
+    }
+
+    /// Verifies that loadGeneralSettings properly parses the sample response.
+    ///
+    func testLoadGeneralSettingsProperlyReturnsParsedSettings() {
+        let remote = SiteSettingsRemote(network: network)
+        let expectation = self.expectation(description: "Load site settings")
+
+        network.simulateResponse(requestUrlSuffix: "settings/general", filename: "settings-general")
+        remote.loadGeneralSettings(for: sampleSiteID) { (siteSettings, error) in
+            XCTAssertNil(error)
+            XCTAssertNotNil(siteSettings)
+            XCTAssertEqual(siteSettings?.count, 20)
+            expectation.fulfill()
+        }
+
+        wait(for: [expectation], timeout: Constants.expectationTimeout)
+    }
+
+    /// Verifies that loadGeneralSettings properly relays Networking Layer errors.
+    ///
+    func testLoadGeneralSettingsProperlyRelaysNetwokingErrors() {
+        let remote = SiteSettingsRemote(network: network)
+        let expectation = self.expectation(description: "Load site settings contains errors")
+
+        remote.loadGeneralSettings(for: sampleSiteID) { (siteSettings, error) in
+            XCTAssertNil(siteSettings)
+            XCTAssertNotNil(error)
+            expectation.fulfill()
+        }
+
+        wait(for: [expectation], timeout: Constants.expectationTimeout)
+    }
+}