[Woo POS] Modularization: fix most Periphery warnings (#16185)

Author: jaclync

Modules/Sources/WooFoundation/Utilities/Connectivity/ConnectivityObserver.swift

@@ -8,12 +8,6 @@ public protocol ConnectivityObserver {
 
     /// Publisher for connectivity availability.
     var statusPublisher: AnyPublisher<ConnectivityStatus, Never> { get }
-
-    /// Starts the observer.
-    func startObserving()
-
-    /// Stops the observer.
-    func stopObserving()
 }
 
 /// Defines the various states of network connectivity.

Modules/Sources/WooFoundation/Utilities/Connectivity/DefaultConnectivityObserver.swift

@@ -29,11 +29,11 @@ public final class DefaultConnectivityObserver: ConnectivityObserver {
         }
     }
 
-    public func startObserving() {
+    private func startObserving() {
         networkMonitor.start(queue: observingQueue)
     }
 
-    public func stopObserving() {
+    func stopObserving() {
         networkMonitor.cancel()
     }
 

Modules/Sources/Yosemite/PointOfSale/POSSearchHistoryService.swift

@@ -4,8 +4,6 @@ import Storage
 public protocol POSSearchHistoryProviding {
     func saveSuccessfulSearch(term: String, for itemType: POSItemType)
     func searchHistory(for itemType: POSItemType) -> [String]
-    func clearSearchHistory(for itemType: POSItemType)
-    func clearAllSearchHistory()
 }
 
 /// Service for managing search history in the Point of Sale
@@ -60,18 +58,4 @@ public final class POSSearchHistoryService: POSSearchHistoryProviding {
     public func searchHistory(for itemType: POSItemType) -> [String] {
         return siteSpecificAppSettingsStoreMethods.getSearchTerms(for: itemType, siteID: siteID)
     }
-
-    /// Clears the search history for a specific item type
-    /// - Parameter itemType: The type of item to clear search history for
-    public func clearSearchHistory(for itemType: POSItemType) {
-        siteSpecificAppSettingsStoreMethods.setSearchTerms([], for: itemType, siteID: siteID)
-    }
-
-    /// Clears all search history
-    public func clearAllSearchHistory() {
-        // Clear search history for all item types
-        POSItemType.allCases.forEach { itemType in
-            clearSearchHistory(for: itemType)
-        }
-    }
 }

Modules/Tests/YosemiteTests/PointOfSale/POSSearchHistoryServiceTests.swift

@@ -89,38 +89,6 @@ struct POSSearchHistoryServiceTests {
         #expect(history.isEmpty)
     }
 
-    @Test func clearSearchHistory_clears_history_for_specific_item_type() throws {
-        // Given
-        sut.saveSuccessfulSearch(term: "product", for: .product)
-        sut.saveSuccessfulSearch(term: "coupon", for: .coupon)
-
-        // When
-        sut.clearSearchHistory(for: .product)
-
-        // Then
-        let productsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.product])
-        let couponsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.coupon])
-        #expect(productsSearchHistory.isEmpty)
-        #expect(couponsSearchHistory.count == 1)
-        #expect(couponsSearchHistory.first == "coupon")
-    }
-
-    @Test func clearAllSearchHistory_clears_all_history() throws {
-        // Given
-        mockStoreMethods.mockSearchTerms[.product] = ["product"]
-        mockStoreMethods.mockSearchTerms[.coupon] = ["coupon"]
-
-        // When
-        sut.clearAllSearchHistory()
-
-        // Then
-        #expect(mockStoreMethods.setSearchTermsCalled)
-        let productsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.product])
-        let couponsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.coupon])
-        #expect(productsSearchHistory.isEmpty)
-        #expect(couponsSearchHistory.isEmpty)
-    }
-
     @Test func search_history_is_separate_for_different_item_types() {
         // Given
         mockStoreMethods.mockSearchTerms[.product] = ["product"]

WooCommerce/Classes/POS/Adaptors/Card Present Payments/CardPresentPaymentCollectOrderPaymentUseCaseAdaptor.swift

@@ -30,7 +30,6 @@ final class CardPresentPaymentCollectOrderPaymentUseCaseAdaptor {
                             CardPresentPaymentTapToPayReaderConnectionAlertsProvider,
                             CardPresentPaymentBluetoothReaderConnectionAlertsProvider,
                             CardPresentPaymentsAlertPresenterAdaptor>,
-                            onboardingPresenter: CardPresentPaymentsOnboardingPresenting,
                             configuration: CardPresentPaymentsConfiguration,
                             alertsPresenter: CardPresentPaymentsAlertPresenterAdaptor,
                             paymentEventSubject: any Subject<CardPresentPaymentEvent, Never>,

WooCommerce/Classes/POS/Adaptors/Card Present Payments/CardPresentPaymentService.swift

@@ -65,7 +65,7 @@ final class CardPresentPaymentService: CardPresentPaymentFacade {
         let connectedReaderPublisher = await Self.createCardReaderConnectionPublisher(stores: stores)
         self.connectedReaderPublisher = connectedReaderPublisher
 
-        readerConnectionStatusPublisher = connectedReaderPublisher
+        readerConnectionStatusPublisher = self.connectedReaderPublisher
             .map({ reader -> CardPresentPaymentReaderConnectionStatus in
                 guard let reader else {
                     return .disconnected
@@ -146,7 +146,6 @@ final class CardPresentPaymentService: CardPresentPaymentFacade {
             using: connectionMethod,
             siteID: siteID,
             preflightController: preflightController,
-            onboardingPresenter: onboardingAdaptor,
             configuration: cardPresentPaymentsConfiguration,
             alertsPresenter: paymentAlertsPresenterAdaptor,
             paymentEventSubject: paymentEventSubject,
@@ -157,7 +156,7 @@ final class CardPresentPaymentService: CardPresentPaymentFacade {
         switch try await paymentTask.value {
         case .success:
             // TODO: fetch the receipt URL to return an accurate value.
-            let transaction = CardPresentPaymentTransaction(receiptURL: URL(string: "https://example.com")!)
+            let transaction = CardPresentPaymentTransaction()
             return .success(transaction)
         case .cancellation:
             return .cancellation

WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalyticsTracking.swift

@@ -4,6 +4,5 @@ public protocol POSCollectOrderPaymentAnalyticsTracking {
     func trackCardReaderReady()
     func trackCardReaderTapped()
     func trackCheckoutTapped()
-    func resetCheckoutTapCountTracker()
     func trackSuccessfulCashPayment()
 }

WooCommerce/Classes/POS/Analytics/POSItemFetchAnalytics.swift

@@ -1,5 +1,4 @@
 import Foundation
-import WooFoundation
 import enum Yosemite.POSItemType
 import protocol Yosemite.POSItemFetchAnalyticsTracking
 

WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSale.swift

@@ -378,7 +378,7 @@ extension WooAnalyticsEvent {
                               properties: [Key.scanner: scanner.analyticsName])
         }
 
-        static func barcodeScannerSetupScannerConnected(scanner: PointOfSaleBarcodeScannerType, step: String) -> WooAnalyticsEvent {
+        static func barcodeScannerSetupScannerConnected(scanner: PointOfSaleBarcodeScannerType) -> WooAnalyticsEvent {
             WooAnalyticsEvent(statName: .pointOfSaleBarcodeScannerSetupScannerConnected,
                               properties: [Key.scanner: scanner.analyticsName])
         }

WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentPreviewService.swift

@@ -29,7 +29,7 @@ final class CardPresentPaymentPreviewService: CardPresentPaymentFacade {
     func collectPayment(for order: Yosemite.Order,
                         using connectionMethod: CardReaderConnectionMethod,
                         channel: PaymentChannel) async throws -> CardPresentPaymentResult {
-        .success(CardPresentPaymentTransaction(receiptURL: URL(string: "https://example.net/receipts/123")!))
+        .success(CardPresentPaymentTransaction())
     }
 
     func cancelPayment() {