Skip to content

Commit f1d73ae

Browse files
committed
Restore accidentally deleted lines in unit test. Add to unit test: test default when date_modified_gmt: null
1 parent a6f62af commit f1d73ae

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Networking/NetworkingTests/Mapper/OrderListMapperTests.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ class OrderListMapperTests: XCTestCase {
1313
XCTAssert(orders.count == 3)
1414

1515
let firstOrder = orders[0]
16+
let dateCreated = DateFormatter.Defaults.dateTimeFormatter.date(from: "2018-04-03T23:05:12")
17+
let dateModified = DateFormatter.Defaults.dateTimeFormatter.date(from: "2018-04-03T23:05:14")
1618
let datePaid = DateFormatter.Defaults.dateTimeFormatter.date(from: "2018-04-03T23:05:14")
1719

1820
XCTAssertEqual(firstOrder.orderID, 963)
@@ -22,6 +24,8 @@ class OrderListMapperTests: XCTestCase {
2224
XCTAssert(firstOrder.status == .processing)
2325
XCTAssertEqual(firstOrder.currency, "USD")
2426
XCTAssertEqual(firstOrder.customerNote, "")
27+
XCTAssertEqual(firstOrder.dateCreated, dateCreated)
28+
XCTAssertEqual(firstOrder.dateModified, dateModified)
2529
XCTAssertEqual(firstOrder.datePaid, datePaid)
2630
XCTAssertEqual(firstOrder.discountTotal, "30.00")
2731
XCTAssertEqual(firstOrder.discountTax, "1.20")
@@ -82,10 +86,13 @@ class OrderListMapperTests: XCTestCase {
8286
let brokenOrder = orders[0]
8387
let format = DateFormatter()
8488
format.dateStyle = .short
89+
8590
let orderCreatedString = format.string(from: brokenOrder.dateCreated)
8691
let todayCreatedString = format.string(from: Date())
92+
XCTAssertEqual(orderCreatedString, todayCreatedString)
8793

88-
XCTAssert(orderCreatedString == todayCreatedString)
94+
let orderModifiedString = format.string(from: brokenOrder.dateModified)
95+
XCTAssertEqual(orderModifiedString, todayCreatedString)
8996
}
9097
}
9198

Networking/NetworkingTests/Responses/broken-order.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
"currency": "GBP",
1111
"date_created": null,
1212
"date_created_gmt": null,
13-
"date_modified": "2018-04-30T20:07:57",
14-
"date_modified_gmt": "2018-04-30T20:07:57",
13+
"date_modified": null,
14+
"date_modified_gmt": null,
1515
"discount_total": "0.00",
1616
"discount_tax": "0.00",
1717
"shipping_total": "0.00",

0 commit comments

Comments
 (0)