Add PointOfSaleOrderControllerTests to confirm CouponsError handling

Author: staskus

WooCommerce/WooCommerceTests/POS/Controllers/PointOfSaleOrderControllerTests.swift

@@ -9,6 +9,8 @@ import struct Yosemite.OrderCouponLine
 import enum Yosemite.OrderAction
 import class WooFoundation.CurrencySettings
 import protocol WooFoundation.Analytics
+import enum Networking.DotcomError
+import enum Networking.NetworkError
 
 struct PointOfSaleOrderControllerTests {
     let mockOrderService = MockPOSOrderService()
@@ -435,6 +437,93 @@ struct PointOfSaleOrderControllerTests {
         #expect(mockOrderService.syncOrderWasCalled == true)
     }
 
+    @available(iOS 17.0, *)
+    @Test func syncOrder_when_orderService_fails_with_couponsError_then_sets_invalidCoupon_error() async throws {
+        // Given
+        let sut = PointOfSaleOrderController(orderService: mockOrderService,
+                                           receiptService: mockReceiptService)
+        let errorMessage = "Invalid coupon code"
+        mockOrderService.errorToReturn = DotcomError.unknown(code: "woocommerce_rest_invalid_coupon", message: errorMessage)
+
+        var orderStates: [PointOfSaleInternalOrderState] = [sut.orderState]
+        var orderStateAppendTask: Task<Void, Never>? = nil
+        await confirmation(expectedCount: 2) { confirmation in
+            @Sendable func observeOrderState() {
+                withObservationTracking {
+                    _ = sut.orderState
+                } onChange: {
+                    orderStateAppendTask = Task { @MainActor in
+                        orderStates.append(sut.orderState)
+                    }
+                    confirmation()
+                    observeOrderState()
+                }
+            }
+            observeOrderState()
+
+            // When
+            await sut.syncOrder(for: .init(items: [makeItem()],
+                                         coupons: [.init(id: UUID(), code: "INVALID")]),
+                              retryHandler: {})
+        }
+
+        await orderStateAppendTask?.value
+
+        // Then
+        #expect(orderStates == [
+            .idle,
+            .syncing,
+            .error(.invalidCoupon(errorMessage), {})
+        ])
+    }
+
+    @available(iOS 17.0, *)
+    @Test func syncOrder_when_orderService_fails_with_networkError_containing_couponsError_then_sets_invalidCoupon_error() async throws {
+        // Given
+        let sut = PointOfSaleOrderController(orderService: mockOrderService,
+                                           receiptService: mockReceiptService)
+        let errorMessage = "Coupon INVALID does not exist"
+        let errorJSON = """
+        {
+            "code": "woocommerce_rest_invalid_coupon",
+            "message": "\(errorMessage)"
+        }
+        """
+        let errorData = errorJSON.data(using: .utf8)!
+        mockOrderService.errorToReturn = NetworkError.unacceptableStatusCode(statusCode: 400, response: errorData)
+
+        var orderStates: [PointOfSaleInternalOrderState] = [sut.orderState]
+        var orderStateAppendTask: Task<Void, Never>? = nil
+        await confirmation(expectedCount: 2) { confirmation in
+            @Sendable func observeOrderState() {
+                withObservationTracking {
+                    _ = sut.orderState
+                } onChange: {
+                    orderStateAppendTask = Task { @MainActor in
+                        orderStates.append(sut.orderState)
+                    }
+                    confirmation()
+                    observeOrderState()
+                }
+            }
+            observeOrderState()
+
+            // When
+            await sut.syncOrder(for: .init(items: [makeItem()],
+                                         coupons: [.init(id: UUID(), code: "INVALID")]),
+                              retryHandler: {})
+        }
+
+        await orderStateAppendTask?.value
+
+        // Then
+        #expect(orderStates == [
+            .idle,
+            .syncing,
+            .error(.invalidCoupon(errorMessage), {})
+        ])
+    }
+
     struct AnalyticsTests {
         private let analytics: WooAnalytics
         private let analyticsProvider = MockAnalyticsProvider()

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSOrderService.swift

@@ -5,6 +5,7 @@ import WooFoundation
 class MockPOSOrderService: POSOrderServiceProtocol {
     var simulateSyncing = false
     var orderToReturn: Order?
+    var errorToReturn: Error?
 
     var syncOrderWasCalled = false
     var updateOrderWasCalled = false
@@ -20,6 +21,10 @@ class MockPOSOrderService: POSOrderServiceProtocol {
             try await Task.sleep(nanoseconds: UInt64(1 * Double(NSEC_PER_SEC)))
         }
 
+        if let error = errorToReturn {
+            throw error
+        }
+
         guard let order = orderToReturn else {
             throw MockPOSOrderServiceError.noOrderToReturn
         }