Rename setPOSTabVisibility to cachePOSTabVisibility to better describe what it does.

Author: jaclync

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -672,7 +672,7 @@ private extension MainTabBarController {
             guard let self, let posEligibilityChecker = self.posEligibilityChecker else { return }
             let eligibility = await posEligibilityChecker.checkEligibility()
             let isPOSTabVisible = eligibility == .eligible
-            setPOSTabVisibilityToAppSettings(siteID: siteID, isPOSTabVisible: isPOSTabVisible)
+            cachePOSTabVisibility(siteID: siteID, isPOSTabVisible: isPOSTabVisible)
             updateTabViewControllers(isPOSTabVisible: isPOSTabVisible)
             viewModel.loadHubMenuTabBadge()
         }
@@ -934,8 +934,8 @@ private extension MainTabBarController {
 }
 
 private extension MainTabBarController {
-    func setPOSTabVisibilityToAppSettings(siteID: Int64, isPOSTabVisible: Bool) {
-        posEligibilityService.setPOSTabVisibility(siteID: siteID, isVisible: isPOSTabVisible)
+    func cachePOSTabVisibility(siteID: Int64, isPOSTabVisible: Bool) {
+        posEligibilityService.cachePOSTabVisibility(siteID: siteID, isVisible: isPOSTabVisible)
     }
 }
 

WooCommerce/WooCommerceTests/Mocks/MockPOSEligibilityService.swift

@@ -8,7 +8,7 @@ final class MockPOSEligibilityService: POSEligibilityServiceProtocol {
         cachedTabVisibility[siteID]
     }
 
-    func setPOSTabVisibility(siteID: Int64, isVisible: Bool) {
+    func cachePOSTabVisibility(siteID: Int64, isVisible: Bool) {
         cachedTabVisibility[siteID] = isVisible
     }
 }

Yosemite/Yosemite/PointOfSale/Eligibility/POSEligibilityService.swift

@@ -9,11 +9,11 @@ public protocol POSEligibilityServiceProtocol {
     /// - Returns: The cached visibility state as a boolean, or nil if no cached value exists.
     func loadCachedPOSTabVisibility(siteID: Int64) -> Bool?
 
-    /// Sets the POS tab visibility state for a specific site.
+    /// Caches the POS tab visibility state for a specific site.
     /// - Parameters:
     ///   - siteID: The ID of the site to set visibility for.
     ///   - isVisible: The visibility state to set.
-    func setPOSTabVisibility(siteID: Int64, isVisible: Bool)
+    func cachePOSTabVisibility(siteID: Int64, isVisible: Bool)
 }
 
 public class POSEligibilityService: POSEligibilityServiceProtocol {
@@ -36,11 +36,11 @@ public class POSEligibilityService: POSEligibilityServiceProtocol {
         return storeSettings.isPOSTabVisible
     }
 
-    /// Sets the POS tab visibility for a given site.
+    /// Caches the POS tab visibility for a given site.
     /// - Parameters:
     ///   - siteID: The site ID to set visibility for.
     ///   - isVisible: The visibility state to set.
-    public func setPOSTabVisibility(siteID: Int64, isVisible: Bool) {
+    public func cachePOSTabVisibility(siteID: Int64, isVisible: Bool) {
         let storeSettings = siteSpecificAppSettingsStoreMethods.getStoreSettings(for: siteID)
         let updatedSettings = storeSettings.copy(isPOSTabVisible: isVisible)
         siteSpecificAppSettingsStoreMethods.setStoreSettings(settings: updatedSettings, for: siteID, onCompletion: nil)

Yosemite/YosemiteTests/PointOfSale/Eligibility/POSEligibilityServiceTests.swift

@@ -48,37 +48,37 @@ struct POSEligibilityServiceTests {
         #expect(result == false)
     }
 
-    // MARK: - setPOSTabVisibility Tests
+    // MARK: - cachePOSTabVisibility Tests
 
-    @Test func setPOSTabVisibility_updates_isPOSTabVisible_to_true() {
+    @Test func cachePOSTabVisibility_updates_isPOSTabVisible_to_true() {
         // Given
         let initialSettings = GeneralStoreSettings(isPOSTabVisible: false)
         mockSiteSpecificAppSettingsStoreMethods.storeSettings = initialSettings
 
         // When
-        sut.setPOSTabVisibility(siteID: siteID, isVisible: true)
+        sut.cachePOSTabVisibility(siteID: siteID, isVisible: true)
 
         // Then
         #expect(mockSiteSpecificAppSettingsStoreMethods.setStoreSettingsCalled == true)
         let updatedSettings = mockSiteSpecificAppSettingsStoreMethods.storeSettings
         #expect(updatedSettings.isPOSTabVisible == true)
     }
 
-    @Test func setPOSTabVisibility_updates_isPOSTabVisible_to_false() {
+    @Test func cachePOSTabVisibility_updates_isPOSTabVisible_to_false() {
         // Given
         let initialSettings = GeneralStoreSettings(isPOSTabVisible: true)
         mockSiteSpecificAppSettingsStoreMethods.storeSettings = initialSettings
 
         // When
-        sut.setPOSTabVisibility(siteID: siteID, isVisible: false)
+        sut.cachePOSTabVisibility(siteID: siteID, isVisible: false)
 
         // Then
         #expect(mockSiteSpecificAppSettingsStoreMethods.setStoreSettingsCalled == true)
         let updatedSettings = mockSiteSpecificAppSettingsStoreMethods.storeSettings
         #expect(updatedSettings.isPOSTabVisible == false)
     }
 
-    @Test func setPOSTabVisibility_preserves_other_settings() {
+    @Test func cachePOSTabVisibility_preserves_other_settings() {
         // Given
         let initialSettings = GeneralStoreSettings(
             storeID: "test-store",
@@ -88,7 +88,7 @@ struct POSEligibilityServiceTests {
         mockSiteSpecificAppSettingsStoreMethods.storeSettings = initialSettings
 
         // When
-        sut.setPOSTabVisibility(siteID: siteID, isVisible: true)
+        sut.cachePOSTabVisibility(siteID: siteID, isVisible: true)
 
         // Then
         let updatedSettings = mockSiteSpecificAppSettingsStoreMethods.storeSettings