Rename posLastIncrementalSyncDate to lastCatalogIncrementalSyncDate.

Author: jaclync

Modules/Sources/Storage/GRDB/Migrations/V001InitialSchema.swift

@@ -19,7 +19,7 @@ struct V001InitialSchema {
     static func createSiteTable(_ db: Database) throws {
         try db.create(table: "site") { siteTable in
             siteTable.primaryKey("id", .integer).notNull()
-            siteTable.column("posLastIncrementalSyncDate", .datetime)
+            siteTable.column("lastCatalogIncrementalSyncDate", .datetime)
         }
     }
 

Modules/Sources/Storage/GRDB/Model/PersistedSite.swift

@@ -6,12 +6,12 @@ public struct PersistedSite: Codable {
     // periphery:ignore - TODO: remove ignore when populating database
     public let id: Int64
     // periphery:ignore - TODO: remove ignore when populating database
-    public let posLastIncrementalSyncDate: Date?
+    public let lastCatalogIncrementalSyncDate: Date?
 
     // periphery:ignore - TODO: remove ignore when populating database
-    public init(id: Int64, posLastIncrementalSyncDate: Date? = nil) {
+    public init(id: Int64, lastCatalogIncrementalSyncDate: Date? = nil) {
         self.id = id
-        self.posLastIncrementalSyncDate = posLastIncrementalSyncDate
+        self.lastCatalogIncrementalSyncDate = lastCatalogIncrementalSyncDate
     }
 }
 
@@ -23,14 +23,14 @@ extension PersistedSite: FetchableRecord, PersistableRecord {
         // periphery:ignore - TODO: remove ignore when populating database
         static let id = Column(CodingKeys.id)
         // periphery:ignore - TODO: remove ignore when populating database
-        static let posLastIncrementalSyncDate = Column(CodingKeys.posLastIncrementalSyncDate)
+        static let lastCatalogIncrementalSyncDate = Column(CodingKeys.lastCatalogIncrementalSyncDate)
     }
 }
 
 // periphery:ignore - TODO: remove ignore when populating database
 private extension PersistedSite {
     enum CodingKeys: String, CodingKey {
         case id
-        case posLastIncrementalSyncDate
+        case lastCatalogIncrementalSyncDate
     }
 }

Modules/Sources/Yosemite/Model/Storage/PersistedSite+Conversions.swift

@@ -5,14 +5,14 @@ extension PersistedSite {
     init(from posSite: POSSite) {
         self.init(
             id: posSite.siteID,
-            posLastIncrementalSyncDate: posSite.lastIncrementalSyncDate
+            lastCatalogIncrementalSyncDate: posSite.lastIncrementalSyncDate
         )
     }
 
     func toPOSSite() -> POSSite {
         POSSite(
             siteID: id,
-            lastIncrementalSyncDate: posLastIncrementalSyncDate
+            lastIncrementalSyncDate: lastCatalogIncrementalSyncDate
         )
     }
 }

Modules/Tests/YosemiteTests/Tools/POS/POSCatalogPersistenceServiceTests.swift

@@ -558,7 +558,7 @@ struct POSCatalogPersistenceServiceTests {
 
             let persistedSite = try PersistedSite.fetchOne(db)
             #expect(persistedSite?.id == siteID)
-            #expect(persistedSite?.posLastIncrementalSyncDate == updatedSyncDate)
+            #expect(persistedSite?.lastCatalogIncrementalSyncDate == updatedSyncDate)
         }
     }
 
@@ -577,7 +577,7 @@ struct POSCatalogPersistenceServiceTests {
         try await db.read { db in
             let persistedSite = try PersistedSite.fetchOne(db)
             #expect(persistedSite?.id == siteID)
-            #expect(persistedSite?.posLastIncrementalSyncDate == nil)
+            #expect(persistedSite?.lastCatalogIncrementalSyncDate == nil)
         }
     }