Hide redundant list row separators

itsmeichigo · itsmeichigo · commit f7ba545b2c4a · 2025-10-31T11:28:33.000+07:00
diff --git a/WooCommerce/Classes/Bookings/BookingFilters/SyncableListSelectorView.swift b/WooCommerce/Classes/Bookings/BookingFilters/SyncableListSelectorView.swift
@@ -77,12 +77,16 @@ private extension SyncableListSelectorView {
                 }
             )
             .renderedIf(viewModel.searchQuery.isEmpty)
+            .listRowSeparator(.hidden, edges: .top)
 
-            ForEach(items, id: \.self) { item in
+            ForEach(Array(items.enumerated()), id: \.element) { (index, item) in
                 optionRow(text: syncable.displayName(for: item),
                           description: syncable.description(for: item),
                           isSelected: selectedItems.contains(where: { $0 == syncable.filterItem(for: item) }),
                           onSelection: { toggleSelectionIfPossible(for: item) })
+                .if(index == 0 && viewModel.searchQuery.isNotEmpty) {
+                    $0.listRowSeparator(.hidden, edges: .top)
+                }
             }
 
             InfiniteScrollIndicator(showContent: viewModel.shouldShowBottomActivityIndicator)

Original file line number	Diff line number	Diff line change
`@@ -77,12 +77,16 @@ private extension SyncableListSelectorView {`
`77`	`77`	`}`
`78`	`78`	`)`
`79`	`79`	`.renderedIf(viewModel.searchQuery.isEmpty)`
	`80`	`+ .listRowSeparator(.hidden, edges: .top)`
`80`	`81`
`81`		`- ForEach(items, id: \.self) { item in`
	`82`	`+ ForEach(Array(items.enumerated()), id: \.element) { (index, item) in`
`82`	`83`	`optionRow(text: syncable.displayName(for: item),`
`83`	`84`	`description: syncable.description(for: item),`
`84`	`85`	`isSelected: selectedItems.contains(where: { $0 == syncable.filterItem(for: item) }),`
`85`	`86`	`onSelection: { toggleSelectionIfPossible(for: item) })`
	`87`	`+ .if(index == 0 && viewModel.searchQuery.isNotEmpty) {`
	`88`	`+ $0.listRowSeparator(.hidden, edges: .top)`
	`89`	`+ }`
`86`	`90`	`}`
`87`	`91`
`88`	`92`	`InfiniteScrollIndicator(showContent: viewModel.shouldShowBottomActivityIndicator)`