Add 501 as terminating for network switching

Author: itsmeichigo

Modules/Sources/NetworkingCore/ApplicationPassword/RequestProcessor.swift

@@ -107,6 +107,8 @@ private extension RequestProcessor {
             } catch {
                 return false
             }
+        case NetworkError.unacceptableStatusCode(let statusCode, let response) where statusCode == 501:
+            fallthrough // treat this the same as 404 code
         case NetworkError.notFound:
             /// Site doesn't support application password
             delegate?.didFailToAuthenticateRequestWithApplicationPassword(siteID: currentSiteID)

Modules/Tests/NetworkingTests/ApplicationPassword/RequestProcessorTests.swift

@@ -326,6 +326,36 @@ final class RequestProcessorTests: XCTestCase {
         }
     }
 
+    func test_delegate_called_when_501_error_occurs_with_wpcom_authentication() throws {
+        // Given
+        let session = Alamofire.Session(configuration: URLSessionConfiguration.default)
+        let request = try mockRequest()
+        let wpcomCredentials = Networking.Credentials.wpcom(username: "test", authToken: "token", siteAddress: "test.com")
+        let mockDelegate = MockRequestProcessorDelegate()
+
+        mockRequestAuthenticator.credentials = wpcomCredentials
+        mockRequestAuthenticator.jetpackSiteID = 123
+        sut.updateAuthenticator(mockRequestAuthenticator)
+        sut.delegate = mockDelegate
+
+        let notSupportedError = NetworkError.unacceptableStatusCode(statusCode: 501, response: nil)
+        mockRequestAuthenticator.mockErrorWhileGeneratingPassword = notSupportedError
+
+        // When
+        let error = RequestAuthenticatorError.applicationPasswordNotAvailable
+        let shouldRetry = waitFor { promise in
+            self.sut.retry(request, for: session, dueTo: error) { shouldRetry in
+                promise(shouldRetry)
+            }
+        }
+
+        // Then
+        XCTAssertFalse(shouldRetry.retryRequired)
+        waitUntil {
+            mockDelegate.didFailToAuthenticateRequestForSiteID == 123
+        }
+    }
+
     func test_request_not_retried_when_other_error_occurs_with_wpcom_authentication() throws {
         // Given
         let session = Alamofire.Session(configuration: URLSessionConfiguration.default)

WooCommerce/Classes/Yosemite/DefaultStoresManager.swift

@@ -178,7 +178,7 @@ class DefaultStoresManager: StoresManager {
                                                                                       queue: .main) { [weak self] note in
             guard let self else { return }
             if isAuthenticatedWithoutWPCom {
-                deauthenticate()
+                _ = deauthenticate()
             }
         }
     }

WooCommerce/WooCommerceTests/Yosemite/StoresManagerTests.swift

@@ -452,6 +452,7 @@ final class StoresManagerTests: XCTestCase {
         MockNotificationCenter.testingInstance.post(name: .ApplicationPasswordsGenerationFailed, object: error, userInfo: nil)
 
         // Assert
+        XCTAssertFalse(manager.isAuthenticated)
         XCTAssertEqual(isLoggedInValues, [false, true, false])
     }