Open
Description
Items to address:
- The current
CollapsibleProductRowCardneeds to move the chevron position to the "header", at the moment appears in the middle of the product row. This involves redoing the component and most likely not use the existingCollapsibleView, so is closer to the design proposal.
| Proposed | Implemented |
|---|---|
 |
 |
- The update to
Feesconflicts with Custom Order Creation project: pecCkj-15v-p2. We may circle back and update them or remove them depending on how the other project goes. For the moment they remain untouched with this project. - The original price should be strike-through when a coupon is applied:
- There should be a "percentage calculation" before the discount when there's a fixed discount entered:
- From [Orders with Coupons M7] Add informational tooltips #10908 (review) , Tooltip improvements:
You should (hopefully) be able to use the .shadow(.drop) modifier here to add the drop shadow.
The × symbol looks huge. It's from another PR but I think it'd be better if you pasted the multiplication symbol into the code and used a localized format string rather than using an image.
Perhaps we should have a simple view for our GridIcons that neatens this up? Doesn't really need to be in this PR but this boilerplate is a bit of a paper cut compared to using SFSymbols (which I still think are better!)
- The
inputFixedField, andinputPercentageFieldused for the discount view has some padding in the text field both leading and trailing, we can start by removing the existingAdaptiveStackand making a plain TextField - From review [Orders with Coupons M7] Make coupons and discounts mutually exclusive #10920 (comment) , extract some view logic to the ViewModel so it's simpler and more testable.
- From review [Orders with Coupons M7] Make coupons and discounts mutually exclusive #10920 (review)
the tooltip for the discount works differently to the one for the coupon
Tapping in the red area does not dismiss the tooltip, we can resolve this the same way we did on b8d3b86 , by moving up the state to the parent view and binding the toggle state between parent and child
