Skip to content

[Mobile Payments] Change CardReaderService to make it clear we only support one connected reader #8683

@joshheald

Description

@joshheald

@toupper:
Technically this means that if any of the connected readers is the Apple Built-in one we don't show the view right? What happens if we are connected to a Bluetooth reader apart from of that?

@joshheald:
Correct, however we don't actually support being connected to more than one reader, and neither do Stripe.

So we can't be connected to more than one at a time, and this class doesn't otherwise handle that situation anyway (it relies on .first to determine the connected reader.)

The proper fix for this inconsistency would be to change connectedReaders to a single object, not an array, but that is way out of scope here 😊

Originally posted in #8666 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature: mobile paymentsRelated to mobile payments / card present payments / Woo Payments.priority: lowNot many people are affected or there’s a workaround, etc.type: technical debtRepresents or solves tech debt of the project.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions