Skip to content

[IPPInAppFeedback] Sometimes the banner label text is not loaded on time, which breaks the view #8747

@iamgabrielma

Description

@iamgabrielma

Describe the bug

I wasn't able to consistently reproduce this problem, it seems to happen sometimes on a iPhone Pro 11 simulator, but I couldn't reproduce it in others, or in a physical device.

Expected banner (1) Broken banner (2) Proposed solution (3)
Simulator Screen Shot - iPhone 14 - 2023-01-25 at 19 01 09 Simulator Screen Shot - iPhone 11 Pro - 2023-01-25 at 19 34 47 Simulator Screen Shot - iPhone 11 Pro - 2023-01-25 at 19 38 29

It would seem that in some cases the TopBannerView is unable to render the content, which causes the other elements in the stack to try and cover the space, this causes as well the icon to appear deformed.

This seems to be introduced with moving the survey content from an UILabel to a StackView since this PR

This seems to be a problem that has happened before, as the code already contemplates a workaround: If no content can be found, let's just remove the component from the superview.

While this proposed solution is not perfect, I'd say is better to display the title and the feedback button rather than showing a broken banner.

To Reproduce
No clear reproduction steps:

  1. Go to Orders
  2. Sometimes, you can see the text does not appear.

I found that by resetting the simulator settings, this resolves sometimes as well, but not always.

Metadata

Metadata

Assignees

Labels

feature: mobile paymentsRelated to mobile payments / card present payments / Woo Payments.type: bugA confirmed bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions