[POS Orders] Hook createdVia from networking to business layer
#15847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
added
type: task
Collaborator
|
|
iamgabrielma
changed the title
createdVia to NetworkingCore Order modelcreatedVia from networking to business layer
staskus
approved these changes
Jul 1, 2025
Contributor
staskus
left a comment
staskus
left a comment
There was a problem hiding this comment.
Tested on a few stores, made orders on IPP, web, and POS. The badge shows up when we would expect. 🚀
| let paymentMethodTitle = try container.decode(String.self, forKey: .paymentMethodTitle) | ||
|
|
||
| // "payment_url" is only available on stores stores with version >= 6.4 | ||
| // "payment_url" is only available on stores with version >= 6.4 |
jaclync
reviewed
Jul 1, 2025
Comment on lines
+81
to
+91
| var salesChannel: String? { | ||
| guard let createdVia = order.createdVia else { | ||
| return nil | ||
| } | ||
|
|
||
| switch createdVia { | ||
| case "pos-rest-api": | ||
| return "POS" | ||
| default: | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
nit: the sales channel implementation detail could live in Yosemite, like an extension of Order, so that the app layer doesn't have to know about this "created_via" property and the sales channel can be reused for other order use cases.
Contributor
Author
There was a problem hiding this comment.
That makes sense 🤔 , I'll go ahead and merge this one for now, then take a spin to your suggestion in #15848
iamgabrielma
deleted the
task/WOOMOB-701-update-networking-model-to-use-createdvia-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-701
Only 1 review is needed.
Description
This PR hooks the usage of
created_viathrough Networking - Yosemite - Storage to finally display the appropriate value in the UI, for this we:NetworkingCore.Ordermodel and generate copy/fakesOrder+ReadOnlyConvertibleto account for this propertycreated_viaas field when we fetch all orders from the APIpos-rest-apiTesting information
.pointOfSaleOrdersi1flag totrue