[POS Orders] Move sales channel representation to Networking #15863

iamgabrielma · 2025-07-03T11:43:47Z

Description

As follow-up from p1751433227323889-slack-CGPNUU63E , we move the sales channel representation from WooCommerce to Networking, removing some code duplication, and avoiding having to handle the pos-rest-api raw value directly in the app layer.

"how about adding the calculated property for order.salesChannel similar to product.productType so that the use cases don't have to work with the raw value? The sales channel can be an enum too like the product type."

Let me know if this is what you had in mind @jaclync , happy to iterate further!

Changes

Declared a SalesChannelType , where the created_via value is passed directly and returns the specific associated case and it's description ( for now, only .pointOfSale - "POS" is handled, any other value will return nil)
Access this description directly from the appropriate cells.

Testing information

Navigate to your orders, POS badges should render both in order list and order details when a POS order is processed (there is no backfilling, you might need to process a fresh POS order if created_via hasn't been set yet)

wpmobilebot · 2025-07-03T11:52:59Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr15863-7df616b`
	Version	`22.7`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`7df616b`
	Installation URL	3iid6t6j8u6c8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma · 2025-07-04T06:33:49Z

WooCommerce/WooCommerceTests/ViewRelated/Orders/OrderListCellViewModelTests.swift


        // Then
-        XCTAssertEqual(viewModel.salesChannel, OrderListCellViewModel.Localization.salesChannelPOSText)
+        XCTAssertEqual(viewModel.salesChannel, "POS")


I had to revert the localization here as now the localized string sits in Networking 🤔

I think this is fine, a bunch of unit tests are already based on the English locale assumption.

jaclync

Thanks for making the updates! LGTM

Unrelated to this PR, the POS badge seems to be truncated in large font size in both the order list and order details. We can also wait for the final design to make any accessibility enhancements.

large font size	small font size

jaclync · 2025-07-04T11:49:23Z

Modules/Sources/NetworkingCore/Model/SalesChannelType.swift

@@ -0,0 +1,32 @@
+import Foundation
+
+public enum SalesChannelType {


nit: how about just SalesChannel? Doesn't seem like there is a naming conflict, just wondering.

No special reason, updated here! 98aaff9

jaclync · 2025-07-04T11:51:21Z

Modules/Sources/NetworkingCore/Model/SalesChannelType.swift

+    public var description: String {
+        switch self {
+        case .pointOfSale:
+            return NSLocalizedString("saleschanneltype.pos.description",


nit: or salesChannel.pos.description depending on the final name of the enum

Suggested change

return NSLocalizedString("saleschanneltype.pos.description",

return NSLocalizedString("salesChannelType.pos.description",

jaclync · 2025-07-04T11:54:37Z

...s/ViewRelated/Orders/Order Details/Order Summary Section/SummaryTableViewCellViewModel.swift

    init(order: Order,
         status: OrderStatus?,
         calendar: Calendar = .current) {
+        self.order = order


nit: I see a salesChannel: String? above, maybe can set either the sales channel description or enum to the salesChannel property here?

True 🤔 , I've updated it on 7df616b but since the enum is in Networking I've continued using a String, in which case we can remove also some duplication around the description

jaclync · 2025-07-04T11:56:09Z

WooCommerce/WooCommerceTests/ViewRelated/Orders/OrderListCellViewModelTests.swift


        // Then
-        XCTAssertEqual(viewModel.salesChannel, OrderListCellViewModel.Localization.salesChannelPOSText)
+        XCTAssertEqual(viewModel.salesChannel, "POS")


I think this is fine, a bunch of unit tests are already based on the English locale assumption.

iamgabrielma · 2025-07-07T02:35:15Z

Thanks for the review!

Unrelated to this PR, the POS badge seems to be truncated in large font size in both the order list and order details. We can also wait for the final design to make any accessibility enhancements.

Good catch, specially the order list details seem to break very easily in larger accessibility sizes, I don't think we'll get much additional design feedback around these badges apart from the recently updated colors, so I'll take a look into this next 👍

make SalesChannelType

875b70a

iamgabrielma added type: task An internally driven task. feature: order details Related to order details. feature: order list Related to the order list. feature: POS labels Jul 3, 2025

iamgabrielma added this to the 22.8 milestone Jul 3, 2025

iamgabrielma added 2 commits July 4, 2025 11:40

Extract SalesChannelType to separate file. Make compile

2cb210e

lint

251eabe

iamgabrielma marked this pull request as ready for review July 4, 2025 06:22

iamgabrielma requested a review from jaclync July 4, 2025 06:22

iamgabrielma commented Jul 4, 2025

View reviewed changes

Base automatically changed from task/update-pos-badge-color to trunk July 4, 2025 10:04

jaclync approved these changes Jul 4, 2025

View reviewed changes

iamgabrielma added 2 commits July 7, 2025 09:21

update enum naming

98aaff9

simplify salesChannel property accessor

7df616b

iamgabrielma enabled auto-merge July 7, 2025 02:38

iamgabrielma merged commit 300a2f9 into trunk Jul 7, 2025
13 checks passed

iamgabrielma deleted the task/move-sales-channel-representation-to-networking branch July 7, 2025 02:53

		@@ -0,0 +1,32 @@
		import Foundation

		public enum SalesChannelType {

	return NSLocalizedString("saleschanneltype.pos.description",
	return NSLocalizedString("salesChannelType.pos.description",

[POS Orders] Move sales channel representation to Networking #15863

[POS Orders] Move sales channel representation to Networking #15863

Uh oh!

Conversation

iamgabrielma commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing information

Uh oh!

wpmobilebot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaclync left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamgabrielma commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iamgabrielma commented Jul 3, 2025 •

edited

Loading

wpmobilebot commented Jul 3, 2025 •

edited

Loading