[Shipping Labels] Handle address array in selected_destination and selected_origin
#15876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelKayumov
added
type: bug
Collaborator
|
|
This was referenced Jul 7, 2025
RafaelKayumov
requested review from
itsmeichigo
and removed request for
itsmeichigo
RafaelKayumov
added
the
status: do not merge
Collaborator
Generated by 🚫 Danger |
Contributor
Author
|
We reviewed the mapping logic. It seems to be impossible to map addresses to labels basing on the address index. Shipment ids reflect the shipment index within an order. But the addresses are being added to the end of array for a purchased label. So if we purchase a label for the 1st shipment in the order, the index of the address would be N and not |
Base automatically changed from
WOOMOB-746-handle-selected-origin
to
release/22.7
July 8, 2025 08:29
Collaborator
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-746
Description
This is a follow up pr for the #15866 and #15872 correspondingly. Addressing the suggestion to handle addresses array as a fallback to support older format.
decodeAddressesmethod to conditionally decode map or array of addresses.Testing steps
I suggest testing on our shared testing store. The order 1951 contains 2 fulfilled shipments with the array format behind
selected_destinationandselected_origin. Or consider creating an order and purchase labels with the 22.6 prod version. For testing purposes make sure the purchased shipping labels origins / destinations are different.config/label-purchase/{order_id}. Addresses returned in the array format should be correctly presented in "ship from" and "ship to" fields of the corresponding fulfilled shipments.RELEASE-NOTES.txtif necessary.