Skip to content

[Woo POS][Barcodes] Partial setup flow for Star BSH-20B #15893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 11, 2025
Merged

[Woo POS][Barcodes] Partial setup flow for Star BSH-20B #15893

merged 7 commits into from
Jul 11, 2025

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Jul 10, 2025 •
edited
Loading

Part of WOOMOB-696

Description

This PR adds the happy path for the Star scanner setup flow. You can set up, connect, and test a scanner.

Currently, the test failure result and documentation step are not implemented.

Note that images, barcodes, and strings are not confirmed yet. I've made TODO tickets for going back to each of these.

I've also not tackled transitions or the correct size of the modal. This is about the flow functionality more than how it looks.

Steps to reproduce

  1. Launch the app and open POS
  2. Tap ... > Barcode scanning
  3. Select Star BSH-20B, and follow the flow
  4. Observe that if you wait before testing the scanner, the text changes to prompt again.
  5. Observe that you can successfully set up the scanner.

Screenshots

star.setup.flow.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 22.9 milestone Jul 10, 2025
@joshheald joshheald added type: task An internally driven task. status: feature-flagged Behind a feature flag. Milestone is not strongly held. feature: POS labels Jul 10, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 10, 2025 •
edited
Loading

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 10, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15893-f29c579
Version22.7
Bundle IDcom.automattic.alpha.woocommerce
Commitf29c579
Installation URL4on9ohmf35lr0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald marked this pull request as ready for review July 10, 2025 12:30
@joshheald joshheald requested a review from staskus July 10, 2025 12:30
@joshheald
Copy link
Contributor Author

joshheald commented Jul 10, 2025

@staskus I can break this down if you prefer, to the setup/pairing in one PR and the test/complete in another... but it's pretty straightforward all together, IMO.

I'm going to change the way steps are held next, to let me change the flow (inserting an error screen if it fails.)

@staskus staskus self-assigned this Jul 10, 2025
staskus
staskus approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 I don't have much to add, the code looks good and the flow works as expected.

...Classes/POS/Presentation/Barcode Scanner Setup/PointOfSaleBarcodeScannerSetupStepViews.swift
}

Button {
guard let targetURL = URL(string: UIApplication.openSettingsURLString) else {
Copy link
Contributor

@staskus staskus Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit annoying because we want to open General or Bluetooth settings, but this URL opens the app's specific settings. I looked up, there's an option to use URL(string: "App-Prefs:root=General", but from some comments, it could be rejected, so maybe it's not worth risking.

Copy link
Contributor Author

@joshheald joshheald Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was my finding as well

@joshheald joshheald merged commit a89afb4 into trunk Jul 11, 2025
30 checks passed
@joshheald joshheald deleted the woomob-696-woo-posbarcodes-set-up-flow-mid-range-star-bsh-2032-b branch July 11, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

Assignees

@staskus staskus

Labels

feature: POS status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

5 participants

@joshheald @dangermattic @wpmobilebot @staskus