Skip to content

[Woo POS] Remove site_id frompos_card_present_collect_payment_success event #15894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

[Woo POS] Remove site_id frompos_card_present_collect_payment_success event #15894

merged 1 commit into from
Jul 11, 2025
+4 −13

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Jul 10, 2025

Continuation of #15892

Description

As @iamgabrielma have noticed, the event already contains blog_id, so we don't need to track site_id separately.

Steps to reproduce

CI success should be enough.

Testing information

Tested on iPad 18.5 simulator

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 22.8 milestone Jul 10, 2025
@staskus staskus requested a review from iamgabrielma July 10, 2025 19:22
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 10, 2025

1 Warning
⚠️ This PR is assigned to the milestone 22.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@staskus
Copy link
Contributor Author

staskus commented Jul 10, 2025 •
edited
Loading

@iamgabrielma I merged #15894, forgetting to push the last fix, including it here. Sorry for the inconvenience.

Please merge before the cut-off if you can. Thanks!

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 10, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15894-124fd47
Version22.7
Bundle IDcom.automattic.alpha.woocommerce
Commit124fd47
Installation URL4i3br7kvg0nso
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma
iamgabrielma approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@iamgabrielma iamgabrielma merged commit a55e970 into trunk Jul 11, 2025
17 of 18 checks passed
@iamgabrielma iamgabrielma deleted the woomob-776-woo-pos-ios-payment-analytics-events-exclude-important-2 branch July 11, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamgabrielma iamgabrielma iamgabrielma approved these changes

Assignees

No one assigned

Labels

feature: POS

Projects

None yet

Milestone

22.8

Development

Successfully merging this pull request may close these issues.

5 participants

@staskus @dangermattic @wpmobilebot @iamgabrielma