Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Jul 15, 2025

For WOOMOB-768

Just one review is required.

Why

This PR hides the retry button in the POS ineligible view when the reason is unsupported iOS version. Since iOS version cannot be changed and refreshed within the app, showing a retry button doesn't make sense for this case.

Description

The implementation adds a computed property shouldShowRetryButton to POSIneligibleReason via a private extension, which returns false for .unsupportedIOSVersion and true for all other cases. The retry button is now conditionally shown using .renderedIf(reason.shouldShowRetryButton).

Additionally, the image in the ineligible UI was updated to X to match the design.

Steps to reproduce

  1. If you don't have a device/simulator with iOS 16 (I personally don't), you can hardcode the ineligible reason to .unsupportedIOSVersion in
    POSIneligibleView(reason: reason, onRefresh: {
  2. Navigate to POS
  3. Observe the ineligible view
  4. Verify that only the "Exit POS" button is shown (no retry button), and the image is an X that matches the design y0zZLi1kqybNUUUd8lmvYG-fi-4133_4689

Testing information

I tested unsupportedIOSVersion (hard-coded) and unsupportedWooCommerceVersion cases (as shown in the screenshots) in iOS 18.4 iPad A16 simulator.

Screenshots

The retry button will no longer appear for unsupported iOS version cases, showing only the "Exit POS" button.

other ineligible reason unsupported iOS version reason
Simulator Screenshot - iPad (A16) - 2025-07-15 at 10 31 07 Simulator Screenshot - iPad (A16) - 2025-07-15 at 10 33 24

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added type: task An internally driven task. feature: POS labels Jul 15, 2025
@jaclync jaclync added this to the 22.9 milestone Jul 15, 2025
@jaclync jaclync changed the title Hide retry CTA for unsupported iOS version in POS ineligible view [POS as a tab i2] Hide retry CTA for unsupported iOS version in POS ineligible view Jul 15, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15914-dabd07e
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commitdabd07e
Installation URL04tfkagk5456o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@jaclync jaclync requested review from iamgabrielma and staskus July 15, 2025 15:10
@iamgabrielma iamgabrielma self-assigned this Jul 16, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't have an <iOS17 device either so I hardcoded the error.

Not necessarily to handle in this PR, but on large sizes the text appears cut off:

Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-07-16 at 12 40 26

@jaclync
Copy link
Contributor Author

jaclync commented Jul 16, 2025

Not necessarily to handle in this PR, but on large sizes the text appears cut off:

Thanks for testing and sharing this, I added a task to the accessibility enhancements issue WOOMOB-750 (Josh also mentioned this before).

@jaclync jaclync merged commit afd4650 into trunk Jul 16, 2025
24 of 26 checks passed
@jaclync jaclync deleted the feat/WOOMOB-768-hide-retry-cta-unsupported-ios-version branch July 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants