Skip to content

Shipping Labels: Allow proceeding with destination address when validation fails #15928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 22, 2025
Merged

Shipping Labels: Allow proceeding with destination address when validation fails #15928

merged 10 commits into from
Jul 22, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 21, 2025 •
edited
Loading

Closes WOOMOB-860

Description

This PR updates the behavior on the destination address edit form to allow proceeding with input address even when validation fails for that address.

A new state confirmed_without_verification has also been added for event wcs_editing_address_step to track when users uses the new CTA.

Testings steps

  1. Log in to a test store with Woo Shipping set up.
  2. Navigate to the Orders tab and select an order eligible for creating shipping labels.
  3. Select Create Shipping Label button > expand the Shipment details bottom sheet.
  4. Tap the pencil button on the Destination address row and update the address to have no street number and tap Validate button.
  5. Confirm that when validation fails, the form displays a CTA "Use address as entered".
  6. Enter a street number for the address, confirm that the CTA is replaced with the Validation button.
  7. Remove the street number and validate again. When the validation fails, tap Use address as entered.
  8. After updating address completes, confirm that wcs_editing_address_step is tracked with state: confirmed_without_verification.
  9. Repeat the steps for an origin address and confirm that the CTA Use address as entered is not displayed when an invalid address is entered.

Testing information

  • Tested and confirmed with simulator iPhone 16 iOS 18.4.
  • Updated unit tests for WooShippingEditAddressViewModel.

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-07-21.at.15.01.19.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.9 milestone Jul 21, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Enhancement labels Jul 21, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 21, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15928-3f3ba1a
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit3f3ba1a
Installation URL62invva4cs1g0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review July 21, 2025 09:09
RafaelKayumov
RafaelKayumov reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing steps work as described 👍

Looks like the canConfirmWithoutVerification state allows too much freedom in terms of invalid data input. For example I entered completely random address city and postal code, not just address. But the form still allowed to "use address as entered". I think the "Use address as entered" should be only available if only the address field is invalid. Not sure though if we have that info.

Form Ship to
Снимок экрана 2025-07-21 в 14 19 54 Снимок экрана 2025-07-21 в 14 24 29

@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Jul 22, 2025

As discussed on Slack, we don't have control over which field(s) can cause an address to be invalid, so we cannot limit the editable fields in this case.

I added new changes to display Unverified status when the Use address as entered button is available. Please take another look when you can.

image

@itsmeichigo itsmeichigo enabled auto-merge July 22, 2025 09:36
@itsmeichigo itsmeichigo merged commit 4cbcf7b into trunk Jul 22, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-860-shipping-labels-allow-proceeding-if-address-is-not-verified branch July 22, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

Enhancement feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @RafaelKayumov