Skip to content

[POS as a tab i1] Remove POS entry point and related code from the Menu tab #15939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

[POS as a tab i1] Remove POS entry point and related code from the Menu tab #15939

merged 3 commits into from
Jul 23, 2025

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Jul 22, 2025 •
edited
Loading

For WOOMOB-916

Just one review is required.

Description

This PR removes the POSEligibilityChecker and POSEligibilityCheckerProtocol code from the codebase to remove the POS entry point implementation in the Menu tab now that we're releasing POS as a tab i2. POS as a tab i1 feature flag will be removed in the next sprint in WOOMOB-917.

The removal includes:

  • Deleted POSEligibilityChecker.swift file and its associated test files
  • Removed all references to POSEligibilityChecker from HubMenuViewModel
  • Removed POS element in the menu tab
  • Updated feature flag documentation

Steps to reproduce

  1. Launch the app with a store eligible for POS
  2. Navigate to the Menu tab
  3. Verify the POS entry point is not shown in the Menu tab
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the type: technical debt Represents or solves tech debt of the project. label Jul 22, 2025
@jaclync jaclync added this to the 22.9 milestone Jul 22, 2025
@jaclync jaclync changed the title Remove POS entry point and corresponding eligibility checker in the Menu tab Remove POS entry point and related code from the Menu tab Jul 22, 2025
@jaclync jaclync changed the title Remove POS entry point and related code from the Menu tab [POS as a tab i1] Remove POS entry point and related code from the Menu tab Jul 22, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 22, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15939-598321d
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit598321d
Installation URL3qmdr6i567ci0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@jaclync jaclync requested a review from staskus July 22, 2025 22:50
@jaclync jaclync merged commit 12600d4 into trunk Jul 23, 2025
15 checks passed
@jaclync jaclync deleted the feat/WOOMOB-916-remove-menu-pos-entry-point branch July 23, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

Assignees

No one assigned

Labels

feature: POS type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

4 participants

@jaclync @wpmobilebot @staskus