Integrate periphery: add fancier reporting #15984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
added
the
category: tooling
1 task
Collaborator
|
|
Contributor
Author
|
CI build with no violation looks like this 🎉 |
Add --disable-update-check and --relative-results flags DRY some code to avoid repetition of the commands to run scan
AliSoftware
force-pushed
the
integrate-periphery-fancy
branch
from
a257cc4 to
0203b2f
Compare
Contributor
Author
|
CI build with some violations (added on purpose here) looks like this: (Note that the violations are still printed in the CI job logs too; so if someone doesn't know to look at the annotations and for some reason just looked at the job logs instead they'd still see the same info) |
This reverts commit 0203b2f.
Contributor
Author
|
@RafaelKayumov Dummy changes I made to introduce fake violations have been reverted and both cases have been tested, so the PR is now ready for review 😃 (I should have set the PR to draft while I was experimenting… sorry… 🙃 ) |
RafaelKayumov
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR targets the HEAD branch
integrate-peripheryof #15962This PR adds some optional improvements/suggestions on top of #15962.
Feel free to discard, or keep, or only merge later, but I figured opening a separate PR would allow to unblock the merging of the main one while allowing to iterate on improvements if needed 🙂
.buildkite/commands/run-periphery.shsetup-and-run-periphery.shperiphery scan "$@"--disable-update-checkflag in the periphery call since thesetup-and-run-periphery.shscript already handles version checks--relative-resultsflag to use relative paths in the output (instead of the absolute paths which are long and not super useful especially in CI context)