[WCiOS17] Update CurrencyCode to use Currency.isoCurrencies
#15992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
added
type: task
Collaborator
|
|
joshheald
approved these changes
Aug 8, 2025
Contributor
joshheald
left a comment
joshheald
left a comment
There was a problem hiding this comment.
Works as expected, one suggestion inline.
| public var wrappedValue: String { | ||
| get { | ||
| guard Locale.isoCurrencyCodes.map({ $0.uppercased() }).contains(value.uppercased()) else { | ||
| guard Locale.Currency.isoCurrencies.map({ $0.identifier }).contains(value.uppercased()) else { |
Contributor
There was a problem hiding this comment.
I'd suggest keeping the .uppercased() for both parts of the comparison, just for good practice.
While the enum definitions are all upper-case, there doesn't appear to be anything in ISO-4217 saying they have to be. Stripe use lower case, which is the reason for this wrapper even existing.
Since we're converting one side of the comparison, it's probably safest/clearest to mirror that on the other side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-103
Description
This PR addresses the
Locale.isoCurrencyCodesdeprecation warning, and to useLocale.Currency.isoCurrenciesinstead.The return type of the built-in function is updated from
[String]to[Locale.Currency], so we use theidentifierproperty to extract the currency value. Applyinguppercased()to the iso currency before comparing the wrapped value is redundant, so I left it out.Testing information
PaymentIntentParametersBuilderand such.You can add a breakpoint to return
value.lowercased()to observe that nothing is off when performing currency comparison and returning the lowercase version of the iso identifier.RELEASE-NOTES.txtif necessary.