Skip to content

[WCiOS17] Update languageCode and regionCode deprecation #15996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[WCiOS17] Update languageCode and regionCode deprecation #15996

merged 1 commit into from
Aug 11, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Aug 8, 2025

Part of WOOMOB-103

Description

Similarly to #15992, we update the usage of languageCode and regionCode in Locale.current to use the new identifier property instead.

Testing information

  • Put a breakpoint in JustInTimeMessageStore.localeLanguageRegionIdentifier and run the app
  • In the console confirm that the output of before and after is the same, in my case:
(lldb) po Locale.current.language.languageCode?.identifier
▿ Optional<String>
  - some : "en"
(lldb) po Locale.current.region?.identifier
▿ Optional<String>
  - some : "TH"
(lldb) po "\(languageCode)_\(regionCode)"
"en_TH"

@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Aug 8, 2025
@iamgabrielma iamgabrielma added this to the 23.1 milestone Aug 8, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review August 8, 2025 08:08
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 8, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15996-c5d9c03
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commitc5d9c03
Installation URL04opiva8kia50
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma requested a review from joshheald August 8, 2025 08:59
joshheald
joshheald approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Base automatically changed from task/ios17-currencycode to trunk August 11, 2025 02:28
@iamgabrielma iamgabrielma merged commit 5a9f525 into trunk Aug 11, 2025
25 checks passed
@iamgabrielma iamgabrielma deleted the task/ios17-languageCode-deprecation branch August 11, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshheald joshheald joshheald approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Milestone

23.1

Development

Successfully merging this pull request may close these issues.

4 participants

@iamgabrielma @wpmobilebot @joshheald