Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

Merge #16021 first
Closes WOOMOB-1040 and WOOMOB-1165

Description

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It doesn’t seem to be straight-forward to push one of the elements of a List down to the bottom, while keeping the rest at the top, so “Help” has to be outside the List.
We also remove the navigation stack from the settings view as a parent, otherwise is part of the nav stack, and presenting any other destination would cover it full-screen. We only make the details right-side part of the nav stack instead.
Dismissal does not show anymore in the parent settings view since we don’t us a navigation stack, and we cannot use a navigation stack otherwise the destinations will be presented full-screen, so we move dismissal to each subview.
@iamgabrielma iamgabrielma added this to the 23.2 milestone Aug 25, 2025
@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Aug 25, 2025
@iamgabrielma iamgabrielma changed the base branch from trunk to task/WOOMOB-1025-two-panel-settings-view August 25, 2025 04:01
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma changed the base branch from task/WOOMOB-1025-two-panel-settings-view to trunk August 25, 2025 04:02
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16032-8e62676
Version23.1
Bundle IDcom.automattic.alpha.woocommerce
Commit8e62676
Installation URL2bssadbtosq1g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma
Copy link
Contributor Author

Closed via #16034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants