[Application Passwords] Add experimental feature toggle in app settings #16059

RafaelKayumov · 2025-08-29T12:13:51Z

Part of WOOMOB-1189

Description

Implements an experimental feature toggle for "Application Passwords Experiment" feature

Adds isApplicationPasswordsSwitchEnabled property to GeneralAppSettings
Implements AppSettings actions to access the corresponding setting
Adds BetaFeature.applicationPasswords to be displayed in experimental features as a toggle.
Adds the settings_beta_features_application_passwords_toggled analytics event triggered by the feature toggle.
Adds ApplicationPasswordsExperimentAvailabilityChecker draft as an async wrapper around upcoming remote FF.
Stores presumable remote feature flag value in local cache for initial presentation.
Evaluates both feature state and availability to determine if it should be applied. ApplicationPasswordsExperimentState handles that.
Observes the beta feature enabled/disabled state and toggles the Application Passwords feature and updates RequestAuthenticator in runtime.
Adds a link to Application Passwords doc in beta feature section footer description.

Testing steps

Run the app on a site that supports application passwords.
Navigate to the app settings -> Experimental Features.
Make sure the "Application Passwords" entry is displayed. Make sure the corresponding description contains an embedded documentation link. Make sure the link is opened in Safari sheet.
Toggle the feature setting and restart the app. Make sure the state is persisted between app sessions.
Use Proxyman to check the behaviour:
- With the toggle isON make sure confirm that supported Jetpack requests are made as direct REST requests with the remote sites.
- In Experimental Features screen toggle the Application Passwords feature off.
- (After a possible delay) Make sure JP requests are performed as usual.
- Toggle the feature back ON.
- (After a possible delay) Make sure requests are performed as direct REST requests.
- Manually imitate the remote FF disabled state mocking the feature unavailability - in ApplicationPasswordsExperimentAvailabilityChecker set the mockResultValue to false. Make sure the setting entry disappears in "Experimental Features". Make sure JP requests are made as usual despite the prior toggle state.

Screenshots

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dangermattic · 2025-08-29T12:14:51Z

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 23.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

wpmobilebot · 2025-08-29T12:23:38Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16059-021e0d4`
	Version	`23.1`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`021e0d4`
	Installation URL	4vuf6g4k0bmeo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

itsmeichigo

This works great 👍 I left some non-blocking comments and questions.

itsmeichigo · 2025-09-03T03:34:32Z

RELEASE-NOTES.txt

 23.2
 -----
-
+- [*] Adds a toggle for Application Passwords feature in Experimental Features settings screen [https://github.com/woocommerce/woocommerce-ios/pull/16059]


Nit: since the feature is not enabled yet, this will not be available to users in version 23.2. Let's remove this.

Reverted in 9026d48

itsmeichigo · 2025-09-03T03:40:18Z

...ommerce/Classes/ViewRelated/Dashboard/Settings/Beta features/BetaFeaturesConfiguration.swift

+                Section(
+                    footer: VStack(
+                        alignment: .leading,
+                        spacing: Layout.spacing


Super nit: is this spacing redundant? There seems to be only one item in the VStack in both cases.

Yes. Previously I attempted a solution with a separate Link element. The redundant spacing remained. I'm gonna remove VStack at all.

Done in 4c6321a

itsmeichigo · 2025-09-03T03:45:28Z

WooCommerce/Classes/Yosemite/AuthenticatedState.swift

+        DispatchQueue.main.async {
+            self.checkApplicationPasswordExperimentFeatureState()
+        }


Nit: Should this be simplified:

Suggested change

DispatchQueue.main.async {

self.checkApplicationPasswordExperimentFeatureState()

}

Task { @MainActor in

await checkApplicationPasswordExperimentFeatureState()

}

Then make checkApplicationPasswordExperimentFeatureState async for better testability if we need to test it.

itsmeichigo · 2025-09-03T04:00:20Z

WooCommerce/Classes/Yosemite/AuthenticatedState.swift

+            .betaFeatureEnabledPublisher(
+                .applicationPasswords
+            )
+            .dropFirst()


❓ Why is it necessary to drop the initial value?

I added dropFirst because eventually the generalAppSettings.betaFeatureEnabledPublisher automatically emits the current toggle state value upon subscription. Without the dropFirst it would also trigger the checkApplicationPasswordExperimentFeatureState() here. But the initial checkApplicationPasswordExperimentFeatureState call happens in AuthenticatedState.init.

Open to improvement suggestions.

I think dropFirst should be used with caution to avoid missing data. Since removeDuplicates is already in place, it should be sufficient for avoiding triggering checkApplicationPasswordExperimentFeatureState when unnecessary.

itsmeichigo · 2025-09-03T09:48:33Z

WooCommerce/Classes/Extensions/UserDefaults+Woo.swift

        case hiddenStoreIDs
+
+        // Application passwords experiment remote FF cached value
+        case applicationPasswordsExperimentRemoteFFValue


Another suggestion: should we clear this flag in SessionManager.reset?

Done in a085407

…eset

…re-toggle # Conflicts: # WooCommerce/Classes/System/SessionManager.swift

RafaelKayumov added 4 commits August 28, 2025 23:53

Draft application passwords feature toggle

00c7fef

Add feature async availability checker stub

e82a95b

Cache remote FF state in user defaults

e5f2034

Use app setting instead of feature flag

30a6663

RafaelKayumov added this to the 23.2 milestone Aug 29, 2025

RafaelKayumov added the type: task An internally driven task. label Aug 29, 2025

RafaelKayumov added 6 commits August 31, 2025 23:42

Check both experiment availability and enabled state

94e35f0

Observe app passwords experiment setting state

64ebccc

Delete extra value prepend for defaultSite

409fde3

Fix methods description comments

5fd10d6

Add link for Application Passwords toggle description

b4a3deb

Update release notes

5d2c609

RafaelKayumov added the category: tracks Related to analytics, including Tracks Events. label Sep 1, 2025

RafaelKayumov added 2 commits September 1, 2025 14:23

Update tests

3709103

Fix unused code

9194cd4

RafaelKayumov force-pushed the WOOMOB-1189-add-application-passwords-feature-toggle branch from cdb0d88 to 9194cd4 Compare September 1, 2025 12:20

Add tests for ApplicationPasswordsExperimentState

b432ac3

RafaelKayumov marked this pull request as ready for review September 1, 2025 13:08

RafaelKayumov requested a review from itsmeichigo September 1, 2025 13:08

itsmeichigo self-assigned this Sep 3, 2025

itsmeichigo approved these changes Sep 3, 2025

View reviewed changes

itsmeichigo reviewed Sep 3, 2025

View reviewed changes

RafaelKayumov added 5 commits September 4, 2025 00:14

Undo the release note

9026d48

Remove redundant VStack from section footer

4c6321a

Reset cached applicationPasswordsExperimentRemoteFFValue on session r…

a085407

…eset

Merge branch 'trunk' into WOOMOB-1189-add-application-passwords-featu…

2db13bc

…re-toggle # Conflicts: # WooCommerce/Classes/System/SessionManager.swift

Delete unused constant

021e0d4

RafaelKayumov merged commit fa8489e into trunk Sep 3, 2025
15 checks passed

RafaelKayumov deleted the WOOMOB-1189-add-application-passwords-feature-toggle branch September 3, 2025 22:39

[Application Passwords] Add experimental feature toggle in app settings #16059

[Application Passwords] Add experimental feature toggle in app settings #16059

Uh oh!

Conversation

RafaelKayumov commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing steps

Screenshots

Uh oh!

dangermattic commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RafaelKayumov commented Aug 29, 2025 •

edited

Loading

dangermattic commented Aug 29, 2025 •

edited

Loading

wpmobilebot commented Aug 29, 2025 •

edited

Loading