Skip to content

[WCiOS17] Update .onchange() usage to iOS17 API v2 #16080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 8, 2025
Merged

[WCiOS17] Update .onchange() usage to iOS17 API v2 #16080

merged 6 commits into from
Sep 8, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Sep 4, 2025

Part of WOOMOB-1003
Continuation from #16002

Description

This PR addresses the remaining warnings related to the .onChange usage across Kiwi features (sort of), by moving them to use the new iOS17+ API.

The previous API has been updated and deprecated from forcing us to use 1 parameter, to instead:

  • Use a zero-parameter closure when we don’t care about the value.
  • Use a two-parameter closure (oldValue, newValue) if we need at least one of them.

All changes are a refactor, so no behavior should be changed. Most of times we either don't care about the value and just react to it, or we care about newValue only.

Testing information

  • Changes affect multiple files, superficial smoke testing of Jetpack connection, Blaze, and Shipping of the affected files/flows should be fine.
  • CI should pass

Screenshots

N/A

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 4, 2025 •
edited
Loading

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added the type: task An internally driven task. label Sep 4, 2025
@iamgabrielma iamgabrielma added this to the 23.2 milestone Sep 4, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review September 4, 2025 09:09
@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Sep 4, 2025 •
edited
Loading

👋 @RafaelKayumov @itsmeichigo adding you both to review since is mostly related to Kiwi features, one review is enough. Does not need to go into 23.2, can wait till next release.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 4, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16080-3d22653
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit3d22653
Installation URL0f7uimm0hp1ao
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot wpmobilebot modified the milestones: 23.2, 23.3 Sep 5, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025

Version 23.2 has now entered code-freeze, so the milestone of this PR has been updated to 23.3.

@itsmeichigo itsmeichigo self-assigned this Sep 5, 2025
itsmeichigo
itsmeichigo approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this 🥇

I did smoke test on some of the more obvious paths: product creation AI, Blaze, and shipping labels. Some changes are more related to POS like FormattableAmountTextField and the measureHeight and measureFrame modifiers, so it'd be nice if you could double check those.

@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Sep 5, 2025 •
edited
Loading

Thanks for the review!

Some changes are more related to POS like FormattableAmountTextField and the measureHeight and measureFrame modifiers, so it'd be nice if you could double check those.

Sure thing, I tested those on my end and I saw no issues 👍

@iamgabrielma iamgabrielma merged commit df47d32 into trunk Sep 8, 2025
14 checks passed
@iamgabrielma iamgabrielma deleted the task/ios17-warnings-onChange-deprecation-2 branch September 8, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@RafaelKayumov RafaelKayumov Awaiting requested review from RafaelKayumov

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

5 participants

@iamgabrielma @dangermattic @wpmobilebot @itsmeichigo