Application password experiment: Clear flagged sites after 14 days #16107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
itsmeichigo
changed the title
RafaelKayumov
approved these changes
Sep 9, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
LGTM. Left just 1 nit
| return false | ||
| } | ||
|
|
||
| let timeElapsed = Date().timeIntervalSince1970 - flagDate.timeIntervalSince1970 |
Contributor
There was a problem hiding this comment.
Nit: There is a method to obtain difference between dates
let timeElapsed = Date().timeIntervalSince(flagDate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1187
Description
This PR adds the capability to clear sites flagged as unsupported for network switching to direct requests after 14 days. This is to ensure that sites can take advantage of the switch if app passwords are enabled again.
Changes include:
applicationPasswordUnsupportedListto dictionary of type [String: Date] to store site IDs along with the flagged date. String is required as dictionaries stored inUserDefaultsneed to be compliant to property list type with keys being strings.Testing steps
Follow the TC7 test steps from here pe5sF9-4Am-p2.
Testing information
Tested and confirmed TC7 with the alpha build on my iPhone.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.