Skip to content

Use remote feature flag to use application passwords for Jetpack Sites #16126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2025
Merged

Use remote feature flag to use application passwords for Jetpack Sites #16126

merged 3 commits into from
Sep 19, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Sep 15, 2025 •
edited
Loading

Closes WOOMOB-1124

Description

This PR replaces the local feature flag with the remote feature flag to check for availability of network switching for Jetpack sites.

Testing steps

Testing 23.2 build

  • Ensure that the build is version 23.2 or lower.
  • Log in to a Jetpack store with WPCom credentials.
  • Confirm in Menu > Settings > Experimental Features there's no option for application passwords switching.
  • Confirm that network requests are Jetpack proxied.

Testing 23.3 build

  • In the General setting tab of WooCommerce target, update the app version to 23.3 and build the app (skip this test if you're testing a beta build of 23.3).
  • Log in to a Jetpack store with WPCom credentials. Ensure that the store has app passwords enabled.
  • Confirm in Menu > Settings > Experimental Features there's an option for application passwords switching and it's enabled by default.
  • Confirm that network requests are direct without Jetpack proxy.

Testing information

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.3 milestone Sep 15, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Sep 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 15, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 23.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 15, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16126-5eb23ae
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit5eb23ae
Installation URL0d729ke9ncssg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review September 18, 2025 05:03
RafaelKayumov
RafaelKayumov approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as described.

@itsmeichigo itsmeichigo merged commit 24eb45c into trunk Sep 19, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1124-remote-feature-flag branch September 19, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @RafaelKayumov