Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 15, 2025

WOOMOB-1269

Description

Hides "grouped" and "variable" product types from selector in product creation and product editing forms.

  • The product types set logic sits in ProductTypeBottomSheetListSelectorCommand. From now on it uses CIABEligibilityChecker to determine if "grouped" and "variable" product types should be added into data set and thus presented in selector.
  • Added tests

Smoke testing steps (Non-CIAB)

  • Use testing site that doesn't contain "garden" or "ciab" in name (this is the temp CIAB / non-CIAB site distinguishing logic).
  • Navigate to "products" tab and tap on "+" button in top right to open product creation sheet.
  • Select "add manually" if presented
  • Make sure "variable product" and "grouped product" entries are presented
  • Close the creation sheet and navigate to an existing simple physical product
  • In that product details form tap on the "Product type" row to open product type selection sheet
  • Make sure "grouped" and "variable" types are presented there

CIAB site testing steps

  • In site admin dashboard add "garden" or "ciab" into site name and shave changes
  • Restart the app and make sure the name change took place
  • Repeat the steps from "Smoke testing steps (Non-CIAB)" scenario
  • The "grouped" and "variable" product types shouldn't be displayed in product type selection sheet

Screenshots

Before After
Снимок экрана 2025-09-15 в 13 41 35 Снимок экрана 2025-09-15 в 13 40 32

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.3 milestone Sep 15, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16130-433d647
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit433d647
Installation URL5rcaobj5p4438
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Sep 16, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected :shipit:

@RafaelKayumov RafaelKayumov merged commit ff2f8ee into trunk Sep 16, 2025
22 of 24 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1269-hide-grouped-and-variable-products-types branch September 16, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants