Skip to content

Ignore build directory in .swiftlint #16179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Ignore build directory in .swiftlint #16179

merged 1 commit into from
Sep 29, 2025

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Sep 29, 2025

Description

Local build or rake lint started failing for me since .swiftlint tries to lint packages that are within build folder:

woocommerce-ios/build/SourcePackages/checkouts/swift-algorithms/Sources/Algorithms/AdjacentPairs.swift:157:1: warning: Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)

I cannot find the reason why my packages are now built in a non-ignored directory for swiftlint, but given this folder is also within.gitignore, I think the change makes sense.

Steps to reproduce

  • CI should succeed
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 23.4 milestone Sep 29, 2025
@staskus staskus added the type: task An internally driven task. label Sep 29, 2025
@staskus staskus requested a review from joshheald September 29, 2025 10:37
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 29, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16179-bb9b9bc
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commitbb9b9bc
Installation URL3ea5diaehr8fg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald self-assigned this Sep 29, 2025
joshheald
joshheald approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but confusing. I don't have a build folder at all.

Your logic on excluding makes sense though.

@staskus staskus merged commit f1e3742 into trunk Sep 29, 2025
17 of 18 checks passed
@staskus staskus deleted the fix/ignore-build-directories-for-swiftlint branch September 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshheald joshheald joshheald approved these changes

@iamgabrielma iamgabrielma Awaiting requested review from iamgabrielma

Assignees

@joshheald joshheald

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.4

Development

Successfully merging this pull request may close these issues.

4 participants

@staskus @wpmobilebot @joshheald