Skip to content

[WCiOS17] Update PaymentsRow to not use NavigationLink API #16195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

[WCiOS17] Update PaymentsRow to not use NavigationLink API #16195

merged 4 commits into from
Oct 2, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Oct 2, 2025 •
edited
Loading

Closes WOOMOB-1301
Closes WOOMOB-1304

Description

This PR updates the PaymentsRow component from Menu > Settings to not use deprecated NavigationLink(isActive:) API for navigation. It also removes the remaining iOS17 availability checks, mainly in previews.

Changes

The only usage of navigation link with isActive binding across the existing payment rows is in 2 instances:

  • "Order Card Reader" row
  • "Card Reader Manuals" row

The rest of rows either use a .sheet, or are wrapped in a button. Since the parent view (InPersonPaymentsMenu is already wrapped in a NavigationStack, we can simplify the view and handle the rows as we already handle the rest via .navigationDestination in the parent.

Testing information

  • Navigate to Menu > Payments
  • Observe that tapping the rows, they behave normally. Specifically Order Card Reader and Card Reader Manuals rows

Tested on iPhone 16 plus - iOS 18.3 simulator, and iPhone 14 18.6.2 physical device

Simulator Screen Recording - iPhone 16 Plus - US store - 2025-10-02 at 12 43 21

@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Oct 2, 2025
@iamgabrielma iamgabrielma added this to the 23.5 milestone Oct 2, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review October 2, 2025 05:18
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 2, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16195-d883fe5
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commitd883fe5
Installation URL4mjrcugi0hkfo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma requested a review from jaclync October 2, 2025 05:53
@iamgabrielma iamgabrielma mentioned this pull request Oct 2, 2025
Merged
jaclync
jaclync approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, worked as expected :shipit:

@iamgabrielma iamgabrielma modified the milestones: 23.5, 23.4 Oct 2, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma merged commit 6c8c1e0 into trunk Oct 2, 2025
16 of 17 checks passed
@iamgabrielma iamgabrielma deleted the task/wcios17-payment-row branch October 2, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Milestone

23.4

Development

Successfully merging this pull request may close these issues.

5 participants

@iamgabrielma @wpmobilebot @dangermattic @jaclync