Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Oct 16, 2025

Closes WOOMOB-1497
Closes WOOMOB-1479

Description

In this PR we update the survey URLs to the real surveys, as well as we add tracks for when the notification is displayed, and when is tapped

  1. Update POSNotificationScheduler.timeIntervalInSeconds to something like 5 seconds. And add the reset trigger to its initializer if you've tested surveys before:
Task { @MainActor in
  let action = AppSettingsAction.resetPOSSurveyNotificationScheduled { _ in }
  stores.dispatch(action)
}
  1. On a physical device, with notifications turned on, and in a US/UK store:
  2. Create an order, observe that the displayed and tapped events are tracked for the woo_pos_survey_potential_user_survey case:
🔵 Tracked local_notification_displayed, type: woo_pos_survey_potential_user_survey,

🔵 Tracked local_notification_tapped, type: woo_pos_survey_potential_user_survey,
  1. Confirm survey appears properly on screen.
  2. Enter POS > stop the app > remove the reset trigger from the initializer to be sure that the POS visited once persists > and re-run the app > Go to POS again
  3. Observe that the displayed and tapped events are tracked for the woo_pos_survey_current_user_survey case:
🔵 Tracked local_notification_displayed,  type: woo_pos_survey_current_user_survey,
🔵 Tracked local_notification_tapped, type: woo_pos_survey_current_user_survey,
  1. Confirm survey appears properly on screen.

TODO:

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 16, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Oct 16, 2025
@iamgabrielma iamgabrielma added this to the 23.5 milestone Oct 16, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review October 16, 2025 07:10
@iamgabrielma iamgabrielma added the category: tracks Related to analytics, including Tracks Events. label Oct 16, 2025
@iamgabrielma iamgabrielma requested a review from staskus October 16, 2025 07:15
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16248-e985bdf
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commite985bdf
Installation URL203pod0v4vl60
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from task/WOOMOB-1498-pos-surveys-complete-eligibility-checks to trunk October 16, 2025 09:49
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Notifications work
✅ Links works
✅ Tracks work

One comment:

CfT for Android mentioned that existing user notification is shown after the Woo app was opened and if POS was opened at least once. And iOS requires for the POS itself to be opened. Let's clarify that to align the platforms 👍

@iamgabrielma iamgabrielma merged commit 4c94cf1 into trunk Oct 17, 2025
29 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-1497-1479-pos-survey-prod-urls-and-tracks branch October 17, 2025 02:26
@iamgabrielma
Copy link
Contributor Author

CfT for Android mentioned that existing user notification is shown after the Woo app was opened and if POS was opened at least once. And iOS requires for the POS itself to be opened. Let's clarify that to align the platforms

That's a good detail, will ask in the channel. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants