Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Oct 29, 2025

Closes WOOMOB-1382

Description

This PR fixes the linked issue by setting the outer view to dismiss the keyboard when content is scrolled.

Test Steps

  1. Start creating a manual order in the app.
  2. Tap Add customer details.
  3. Click the + icon.
  4. Enter the postcode.
  5. Scroll to the Country field.
  6. Tap on the Country field and select a country from the list.
  7. Note that you can still scroll the Customer Details screen.
  8. Also confirm that the keyboard is not missed if you are changing focus from one input to another without scrolling.

Screenshots

Before After
Simulator Screen Recording - iPhone 17 Pro - 2025-10-29 at 10 05 22 Simulator Screen Recording - iPhone 17 Pro - 2025-10-29 at 10 07 25

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added the type: bug A confirmed bug. label Oct 29, 2025
@adborbas adborbas added this to the 23.6 milestone Oct 29, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 29, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 29, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16289-228281c
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commit228281c
Installation URL1nnm8r37ee2j0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas changed the title Dismiss keyboard on scroll Fix: Customer Details Screen Not Scrollable After Selecting Country Oct 29, 2025
@adborbas adborbas marked this pull request as ready for review October 29, 2025 09:15
@itsmeichigo itsmeichigo self-assigned this Oct 30, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround works, but it makes the experience of editing the form a bit irritating IMO. When I want to tap on a field that is under the keyboard, I'd need to scroll > the keyboard is dismissed > then the keyboard is presented again when I tap on the field I want.

How about addressing the issue a bit differently by dismissing the keyboard before showing the state or country pickers? Something like this:

.onChange(of: showStateSelector) {
    UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}
.onChange(of: showCountrySelector) {
    UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}

@adborbas
Copy link
Contributor Author

This workaround works, but it makes the experience of editing the form a bit irritating IMO. When I want to tap on a field that is under the keyboard, I'd need to scroll > the keyboard is dismissed > then the keyboard is presented again when I tap on the field I want.

How about addressing the issue a bit differently by dismissing the keyboard before showing the state or country pickers? Something like this:

.onChange(of: showStateSelector) {
    UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}
.onChange(of: showCountrySelector) {
    UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}

@itsmeichigo Yeah , this is much better than my initial approach. Thanks for the hint.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@adborbas adborbas merged commit e4b16c1 into trunk Oct 30, 2025
13 checks passed
@adborbas adborbas deleted the adborbas/woomob-1382 branch October 30, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants