Skip to content

Bookings: Update customer filter to support multiple selections #16291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2025
Merged

Bookings: Update customer filter to support multiple selections #16291

merged 7 commits into from
Oct 30, 2025
+393 −92

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 29, 2025 •
edited
Loading

Part of WOOMOB-1240

Description

This PR updates the customer filters to support multiple selections.

Since it's tricky to update the existing customer filter to support multiple selections, I switched to the SyncableListSelectorView solution for booking customer filter instead. I also expanded this view to support searching and conditional selection as guest customers are not supported for filtering.

Test Steps

  1. Log in to a CIAB store with existing bookings.
  2. Navigate to Bookings tab > All > Filter.
  3. Confirm that the customer filter is now named "Customer" instead of "Customer name".
  4. Select Customer and confirm that more than one option can be selected.
  5. Tap on the search bar and enter any keywords. Confirm that the search results are correct.
  6. Tap on a guest customer and confirm that a notice is displayed saying guest customers are not supported for filtering.
  7. Optional: do regression test on Team member and Service/event filtering to ensure both works fine. Also test Customer filtering on the order list to ensure it works as before.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-10-29.at.18.08.43.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.6 milestone Oct 29, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 29, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 29, 2025 •
edited
Loading

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 23.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 29, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16291-b5c3d62
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commitb5c3d62
Installation URL0j9trqddsaufo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review October 29, 2025 15:07
@adborbas adborbas self-assigned this Oct 30, 2025
adborbas
adborbas approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 👍

One small note, the customer list is flickering when opened with data already loaded in it.

Image

@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Oct 30, 2025

One small note, the customer list is flickering when opened with data already loaded in it.

Good catch - that annoys me as well. I removed the loading state in #16294, hopefully that makes the experience better.

@itsmeichigo itsmeichigo merged commit 4b6fed3 into trunk Oct 30, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1240-customer-multiple-selection branch October 30, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adborbas adborbas adborbas approved these changes

@RafaelKayumov RafaelKayumov Awaiting requested review from RafaelKayumov

Assignees

@adborbas adborbas

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.6

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @adborbas