Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Nov 12, 2025

Description

Previously in #16327 I replaced the booking list's accent color with listRowBackground modifier since the accent color affects the header's button color.

Turns out, listRownBackground also comes with a focus ring that cannot be get rid of even with focusEffectDisabled modifier from my testing.

This PR gets rid of the selected border by applying a workaround:

  • Set the list row insets to zero and apply paddings around the row contents manually
  • Set a background color to the row contents for selected state.

Test Steps

  1. Build and run the app on an iPad simulator.
  2. Log in to a CIAB store with existing bookings.
  3. Navigate to the Bookings tab and select any booking in the list.
  4. Confirm that there is no border around selected items.

Screenshots

Before After
Screenshot 2025-11-12 at 10 22 59 image

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.7 milestone Nov 12, 2025
@itsmeichigo itsmeichigo added the type: bug A confirmed bug. label Nov 12, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16343-1497678
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit1497678
Installation URL76t9bvnug4rgo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix. No border spotted.

@itsmeichigo itsmeichigo merged commit 9029e29 into trunk Nov 13, 2025
20 of 21 checks passed
@itsmeichigo itsmeichigo deleted the fix/bookings-list-row-selected branch November 13, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants