diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index 3ac9f4e66fc..c0b4a35096c 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -9,6 +9,7 @@ - [*] Fix order details presentation when opened from booking details [https://github.com/woocommerce/woocommerce-ios/pull/16331] - [*] Show POS feedback surveys for eligible merchants [https://github.com/woocommerce/woocommerce-ios/pull/16325] - [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317] +- [Internal] Fix warning when displaying offline banner on My Store [https://github.com/woocommerce/woocommerce-ios/pull/16347] - [Internal] Notify listeners immediately after updating predicates or sort descriptors for results controllers. [https://github.com/woocommerce/woocommerce-ios/pull/16350] 23.6 diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift index d48fc998938..b1b9f59b425 100644 --- a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift +++ b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift @@ -162,6 +162,10 @@ struct DashboardView: View { storePlanBanner .renderedIf(connectivityStatus != .notReachable) + + OfflineBannerViewRepresentable() + .frame(height: OfflineBannerView.height) + .renderedIf(connectivityStatus == .notReachable) } .sheet(isPresented: $showingSupportForm) { supportForm diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift index a3a63ea08e4..03981a97101 100644 --- a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift +++ b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift @@ -75,10 +75,6 @@ final class DashboardViewHostingController: UIHostingController { await viewModel.reloadAllData() } } - - override var shouldShowOfflineBanner: Bool { - return true - } } // MARK: Private helpers