From 91cd201b20874e21b361b15b83014f6496789377 Mon Sep 17 00:00:00 2001 From: Huong Do Date: Wed, 12 Nov 2025 16:43:14 +0700 Subject: [PATCH 1/2] Add offline banner to dashboard manually --- WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift | 4 ++++ .../Dashboard/DashboardViewHostingController.swift | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift index d48fc998938..b1b9f59b425 100644 --- a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift +++ b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift @@ -162,6 +162,10 @@ struct DashboardView: View { storePlanBanner .renderedIf(connectivityStatus != .notReachable) + + OfflineBannerViewRepresentable() + .frame(height: OfflineBannerView.height) + .renderedIf(connectivityStatus == .notReachable) } .sheet(isPresented: $showingSupportForm) { supportForm diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift index a3a63ea08e4..03981a97101 100644 --- a/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift +++ b/WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift @@ -75,10 +75,6 @@ final class DashboardViewHostingController: UIHostingController { await viewModel.reloadAllData() } } - - override var shouldShowOfflineBanner: Bool { - return true - } } // MARK: Private helpers From 7662fa5bd1dc3a727a9547fcf91c422345412efc Mon Sep 17 00:00:00 2001 From: Huong Do Date: Wed, 12 Nov 2025 16:52:01 +0700 Subject: [PATCH 2/2] Update release notes --- RELEASE-NOTES.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index 8d66caff196..7d8555db23d 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -9,6 +9,7 @@ - [*] Fix order details presentation when opened from booking details [https://github.com/woocommerce/woocommerce-ios/pull/16331] - [*] Show POS feedback surveys for eligible merchants [https://github.com/woocommerce/woocommerce-ios/pull/16325] - [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317] +- [Internal] Fix warning when displaying offline banner on My Store [https://github.com/woocommerce/woocommerce-ios/pull/16347] 23.6 -----