From bbd2d498236fb5ef06330886f083cc0948f371ee Mon Sep 17 00:00:00 2001 From: iamgabrielma Date: Wed, 26 Nov 2025 16:42:08 +0700 Subject: [PATCH 1/5] add all app_store_screenshots to default --- .../default/app_store_screenshot_1.txt | 2 ++ .../default/app_store_screenshot_2.txt | 2 ++ .../default/app_store_screenshot_3.txt | 2 ++ .../default/app_store_screenshot_4.txt | 2 ++ .../default/app_store_screenshot_5.txt | 2 ++ .../default/app_store_screenshot_6.txt | 1 + .../default/app_store_screenshot_7.txt | 1 + .../default/app_store_screenshot_8.txt | 1 + fastlane/screenshots.json | 24 +++++++++++++++++++ 9 files changed, 37 insertions(+) create mode 100644 fastlane/metadata/default/app_store_screenshot_1.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_2.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_3.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_4.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_5.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_6.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_7.txt create mode 100644 fastlane/metadata/default/app_store_screenshot_8.txt diff --git a/fastlane/metadata/default/app_store_screenshot_1.txt b/fastlane/metadata/default/app_store_screenshot_1.txt new file mode 100644 index 00000000000..934799e221b --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_1.txt @@ -0,0 +1,2 @@ +Track sales and +bestselling products \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_2.txt b/fastlane/metadata/default/app_store_screenshot_2.txt new file mode 100644 index 00000000000..23e9c67d7c4 --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_2.txt @@ -0,0 +1,2 @@ +Create orders +on the fly \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_3.txt b/fastlane/metadata/default/app_store_screenshot_3.txt new file mode 100644 index 00000000000..e9af8c48041 --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_3.txt @@ -0,0 +1,2 @@ +Take payments +in person \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_4.txt b/fastlane/metadata/default/app_store_screenshot_4.txt new file mode 100644 index 00000000000..c5a817c0626 --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_4.txt @@ -0,0 +1,2 @@ +Add and edit products +with a touch diff --git a/fastlane/metadata/default/app_store_screenshot_5.txt b/fastlane/metadata/default/app_store_screenshot_5.txt new file mode 100644 index 00000000000..f1d3dcbf79b --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_5.txt @@ -0,0 +1,2 @@ +Get notified of +every sale \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_6.txt b/fastlane/metadata/default/app_store_screenshot_6.txt new file mode 100644 index 00000000000..8eac971071d --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_6.txt @@ -0,0 +1 @@ +Sell online and in person \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_7.txt b/fastlane/metadata/default/app_store_screenshot_7.txt new file mode 100644 index 00000000000..d9066b261f6 --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_7.txt @@ -0,0 +1 @@ +Track orders and view totals in real time \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_8.txt b/fastlane/metadata/default/app_store_screenshot_8.txt new file mode 100644 index 00000000000..2267c51b4a2 --- /dev/null +++ b/fastlane/metadata/default/app_store_screenshot_8.txt @@ -0,0 +1 @@ +Complete payments quickly and efficiently \ No newline at end of file diff --git a/fastlane/screenshots.json b/fastlane/screenshots.json index 6a88d38d027..8e3fa0f4786 100644 --- a/fastlane/screenshots.json +++ b/fastlane/screenshots.json @@ -114,6 +114,30 @@ "background": "appstoreres/assets/ipad-background-1.png", "screenshot": "iPad Pro 13-inch (M4)-5-dark-order-notification.png", "text": "metadata/{locale}/app_store_screenshot_5.txt" + }, + // Sell online and in person + { + "device": "iPad Pro 13-inch (M4)", + "filename": "iPad Pro 13-inch (M4)-06.png", + "background": "appstoreres/assets/ipad-background-2.png", + "screenshot": "iPad Pro 13-inch (M4)-6-light-pos-dashboard.png", + "text": "metadata/{locale}/app_store_screenshot_6.txt" + }, + // Track orders and view totals in real time + { + "device": "iPad Pro 13-inch (M4)", + "filename": "iPad Pro 13-inch (M4)-07.png", + "background": "appstoreres/assets/ipad-background-1.png", + "screenshot": "iPad Pro 13-inch (M4)-7-dark-pos-payment.png", + "text": "metadata/{locale}/app_store_screenshot_7.txt" + }, + // Complete payments quickly and efficiently + { + "device": "iPad Pro 13-inch (M4)", + "filename": "iPad Pro 13-inch (M4)-08.png", + "background": "appstoreres/assets/ipad-background-2.png", + "screenshot": "iPad Pro 13-inch (M4)-8-light-pos-success.png", + "text": "metadata/{locale}/app_store_screenshot_8.txt" } ] } From e03bd88bc72b52103272cecdac2767c45d468c42 Mon Sep 17 00:00:00 2001 From: iamgabrielma Date: Fri, 28 Nov 2025 10:04:49 +0700 Subject: [PATCH 2/5] runs UI POS screenhot tests on iPads only --- .../WooCommerceScreenshots.swift | 40 ++++++++++--------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift b/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift index a10f482f3bf..672bd86ea02 100644 --- a/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift +++ b/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift @@ -74,25 +74,27 @@ class WooCommerceScreenshots: XCTestCase { .goBackToOrderScreen() .goBackToOrdersScreen() - // POS - try TabNavComponent() - .goToPOSScreen() - .tapAddProduct(productID: 1) - .tapAddProduct(productID: 2) - .thenTakeScreenshot(named: "pos-dashboard", orientation: .landscapeLeft) - .tapConnectReader() - .waitForReaderConnected() - .tapCheckout() - .waitForTotalsLoaded() - .waitForCardPaymentReady() - .thenTakeScreenshot(named: "pos-payment", orientation: .landscapeLeft) - .tapCashPayment() - .tapMarkPaymentComplete() - .waitForPaymentSuccess() - .thenTakeScreenshot(named: "pos-success", orientation: .landscapeLeft) - .tapMenuButton() - .tapExitMenuItem() - .confirmExitPOS() + // POS - iPad only + if UIDevice.current.userInterfaceIdiom == .pad { + try TabNavComponent() + .goToPOSScreen() + .tapAddProduct(productID: 1) + .tapAddProduct(productID: 2) + .thenTakeScreenshot(named: "pos-dashboard", orientation: .landscapeLeft) + .tapConnectReader() + .waitForReaderConnected() + .tapCheckout() + .waitForTotalsLoaded() + .waitForCardPaymentReady() + .thenTakeScreenshot(named: "pos-payment", orientation: .landscapeLeft) + .tapCashPayment() + .tapMarkPaymentComplete() + .waitForPaymentSuccess() + .thenTakeScreenshot(named: "pos-success", orientation: .landscapeLeft) + .tapMenuButton() + .tapExitMenuItem() + .confirmExitPOS() + } // Products try TabNavComponent() From 89ad43df9063d7139f87fc441de29af8669924a5 Mon Sep 17 00:00:00 2001 From: iamgabrielma Date: Fri, 28 Nov 2025 11:39:11 +0700 Subject: [PATCH 3/5] use-mocked-card-present-payment for UI tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Despite tests passing, the contents of the pos-payment screenshot was incorrect, as lands on the failure case for `checkOrderIsStillEligibleForPayment` when attempting to retrieve the order details, hence showing a “Error: unable to process payment. we could not fetch the latest order details” rather than the payment view. Despite passing the CPP mock in the POSTabCoordinator, we were never setting it in the test as a launch argument. --- WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift b/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift index 672bd86ea02..6723cd8b915 100644 --- a/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift +++ b/WooCommerce/WooCommerceScreenshots/WooCommerceScreenshots.swift @@ -24,6 +24,7 @@ class WooCommerceScreenshots: XCTestCase { let app = XCUIApplication() setupSnapshot(app) app.launchArguments.append("mocked-network-layer") + app.launchArguments.append("use-mocked-card-present-payment") app.launchArguments.append("-simulate-stripe-card-reader") app.launchArguments.append("disable-animations") app.launchArguments.append("-mocks-push-notification") From 03cc4b2ba4c7371df06796f69e350c0134e4cdd8 Mon Sep 17 00:00:00 2001 From: iamgabrielma Date: Fri, 28 Nov 2025 14:30:08 +0700 Subject: [PATCH 4/5] reorder screenshots to pass create_promo lane Since we run the notification screenshot the last one due to the UI test flow, when we run the create_promo lane then screenshot descriptions are miss-aligned with what they show which fails the job. --- .../metadata/default/app_store_screenshot_5.txt | 3 +-- .../metadata/default/app_store_screenshot_6.txt | 2 +- .../metadata/default/app_store_screenshot_7.txt | 2 +- .../metadata/default/app_store_screenshot_8.txt | 3 ++- fastlane/screenshots.json | 16 ++++++++-------- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/fastlane/metadata/default/app_store_screenshot_5.txt b/fastlane/metadata/default/app_store_screenshot_5.txt index f1d3dcbf79b..8eac971071d 100644 --- a/fastlane/metadata/default/app_store_screenshot_5.txt +++ b/fastlane/metadata/default/app_store_screenshot_5.txt @@ -1,2 +1 @@ -Get notified of -every sale \ No newline at end of file +Sell online and in person \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_6.txt b/fastlane/metadata/default/app_store_screenshot_6.txt index 8eac971071d..d9066b261f6 100644 --- a/fastlane/metadata/default/app_store_screenshot_6.txt +++ b/fastlane/metadata/default/app_store_screenshot_6.txt @@ -1 +1 @@ -Sell online and in person \ No newline at end of file +Track orders and view totals in real time \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_7.txt b/fastlane/metadata/default/app_store_screenshot_7.txt index d9066b261f6..2267c51b4a2 100644 --- a/fastlane/metadata/default/app_store_screenshot_7.txt +++ b/fastlane/metadata/default/app_store_screenshot_7.txt @@ -1 +1 @@ -Track orders and view totals in real time \ No newline at end of file +Complete payments quickly and efficiently \ No newline at end of file diff --git a/fastlane/metadata/default/app_store_screenshot_8.txt b/fastlane/metadata/default/app_store_screenshot_8.txt index 2267c51b4a2..f1d3dcbf79b 100644 --- a/fastlane/metadata/default/app_store_screenshot_8.txt +++ b/fastlane/metadata/default/app_store_screenshot_8.txt @@ -1 +1,2 @@ -Complete payments quickly and efficiently \ No newline at end of file +Get notified of +every sale \ No newline at end of file diff --git a/fastlane/screenshots.json b/fastlane/screenshots.json index 8e3fa0f4786..a892515bd18 100644 --- a/fastlane/screenshots.json +++ b/fastlane/screenshots.json @@ -107,36 +107,36 @@ "screenshot": "iPad Pro 13-inch (M4)-4-light-product-add.png", "text": "metadata/{locale}/app_store_screenshot_4.txt" }, - // Get notified of every sale + // Sell online and in person { "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-05.png", "background": "appstoreres/assets/ipad-background-1.png", - "screenshot": "iPad Pro 13-inch (M4)-5-dark-order-notification.png", + "screenshot": "iPad Pro 13-inch (M4)-5-dark-pos-dashboard.png", "text": "metadata/{locale}/app_store_screenshot_5.txt" }, - // Sell online and in person + // Track orders and view totals in real time { "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-06.png", "background": "appstoreres/assets/ipad-background-2.png", - "screenshot": "iPad Pro 13-inch (M4)-6-light-pos-dashboard.png", + "screenshot": "iPad Pro 13-inch (M4)-6-light-pos-payment.png", "text": "metadata/{locale}/app_store_screenshot_6.txt" }, - // Track orders and view totals in real time + // Complete payments quickly and efficiently { "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-07.png", "background": "appstoreres/assets/ipad-background-1.png", - "screenshot": "iPad Pro 13-inch (M4)-7-dark-pos-payment.png", + "screenshot": "iPad Pro 13-inch (M4)-7-light-pos-success.png", "text": "metadata/{locale}/app_store_screenshot_7.txt" }, - // Complete payments quickly and efficiently + // Get notified of every sale { "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-08.png", "background": "appstoreres/assets/ipad-background-2.png", - "screenshot": "iPad Pro 13-inch (M4)-8-light-pos-success.png", + "screenshot": "iPad Pro 13-inch (M4)-8-dark-order-notification.png", "text": "metadata/{locale}/app_store_screenshot_8.txt" } ] From 89d735d109a9a71d9a11db0860572dc80942f41c Mon Sep 17 00:00:00 2001 From: iamgabrielma Date: Fri, 28 Nov 2025 14:33:27 +0700 Subject: [PATCH 5/5] update screenshot variant --- fastlane/screenshots.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fastlane/screenshots.json b/fastlane/screenshots.json index a892515bd18..dee766f1bdd 100644 --- a/fastlane/screenshots.json +++ b/fastlane/screenshots.json @@ -107,7 +107,7 @@ "screenshot": "iPad Pro 13-inch (M4)-4-light-product-add.png", "text": "metadata/{locale}/app_store_screenshot_4.txt" }, - // Sell online and in person + // Sell online and in person { "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-05.png", @@ -128,7 +128,7 @@ "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-07.png", "background": "appstoreres/assets/ipad-background-1.png", - "screenshot": "iPad Pro 13-inch (M4)-7-light-pos-success.png", + "screenshot": "iPad Pro 13-inch (M4)-7-dark-pos-success.png", "text": "metadata/{locale}/app_store_screenshot_7.txt" }, // Get notified of every sale @@ -136,7 +136,7 @@ "device": "iPad Pro 13-inch (M4)", "filename": "iPad Pro 13-inch (M4)-08.png", "background": "appstoreres/assets/ipad-background-2.png", - "screenshot": "iPad Pro 13-inch (M4)-8-dark-order-notification.png", + "screenshot": "iPad Pro 13-inch (M4)-8-light-order-notification.png", "text": "metadata/{locale}/app_store_screenshot_8.txt" } ]