Skip to content

[release/23.7] Fix variable product selector navigation - pull into release #16424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/23.7
Choose a base branch
from
Open

[release/23.7] Fix variable product selector navigation - pull into release #16424

wants to merge 1 commit into from
+17 −11

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Dec 2, 2025 •
edited
Loading

This PR pulls and applies same changes from Fix variable product selector navigation and applies to 23.7 release.

  • Last minute before approved 23.7 distribution we realised that the fix was targeting 23.8. So we decided to also include it into 23.7.
  • Release note changes weren't pulled.

For more context check out the discussion thread: p1764685912916129/1763384303.329289-slack-C6H8C3G23

Test Steps

  • Try to reproduce the actual issue first in the following environment (that happened in latest trunk too). Check out the WOOMOB-1734 issue for reproduction video.
  • Use inpersonpayments.wpcomstaging.com store with the account listed in Smoke Testing flow: P91TBi-bVe-p2
  • Navigate to order list and start order creation flow
  • Find a variable product in selector list
  • Make sure it's tappable and navigates to variations list
  • Make sure variations selection works fine and applies to an order that's being created/edited.

Important note

I noticed that the issue doesn't happen if running from Xcode. I suggest to double check the behaviour in TF build before submitting for App Store review.

@RafaelKayumov RafaelKayumov added type: bug A confirmed bug. Bug labels Dec 2, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 2, 2025 •
edited
Loading

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 23.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@RafaelKayumov RafaelKayumov added this to the 23.7 milestone Dec 2, 2025
@RafaelKayumov RafaelKayumov marked this pull request as ready for review December 2, 2025 21:57
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16424-952ba9e
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit952ba9e
Installation URL1fc0ne9dk7g2g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@adborbas adborbas Awaiting requested review from adborbas

@toupper toupper Awaiting requested review from toupper

Assignees

No one assigned

Labels

Bug type: bug A confirmed bug.

Projects

None yet

Milestone

23.7

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @dangermattic @wpmobilebot @itsmeichigo