Skip to content

Products Onboarding: Add analytics for onboarding banner #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2022
Merged

Products Onboarding: Add analytics for onboarding banner #7989

merged 2 commits into from
Oct 31, 2022

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Oct 31, 2022 •
edited
Loading

Closes: #7979
⚠️ Depends on #7988 ⚠️

Description

Adds a new analytics event for the products onboarding banner when the call to action is tapped:

  • *_products_onboarding_cta_tapped (Event registration: 1155-gh-tracks-events-registration )

Testing

  1. Build and run the app in debug/alpha mode.
  2. Select a store with no products.
  3. When the onboarding banner appears on the My Store dashboard, tap the "Add a Product" call to action. Confirm the event is triggered.

Submitter Checklist

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added status: feature-flagged Behind a feature flag. Milestone is not strongly held. feature: products onboarding Related to onboarding new users to manage products labels Oct 31, 2022
@rachelmcr rachelmcr added this to the 11.1 milestone Oct 31, 2022
@rachelmcr rachelmcr added the category: tracks Related to analytics, including Tracks Events. label Oct 31, 2022
@rachelmcr rachelmcr marked this pull request as ready for review October 31, 2022 15:36
@rachelmcr rachelmcr linked an issue Oct 31, 2022 that may be closed by this pull request
Products Onboarding: Add banner analytics #7979
Closed
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 31, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7989-3540bf2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Ecarrion
Ecarrion approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do you think we should change this to an AnalyticEvent rather than just tracing the stat id? I think we were leaning towards that as they are more extensible an maintainable towards the future!

Base automatically changed from issue/7978-products-onboarding-banner-buttons to trunk October 31, 2022 17:09
@peril-woocommerce
Copy link

peril-woocommerce bot commented Oct 31, 2022

Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@rachelmcr
Copy link
Contributor Author

rachelmcr commented Oct 31, 2022 •
edited
Loading

Do you think we should change this to an AnalyticEvent rather than just tracing the stat id? I think we were leaning towards that as they are more extensible an maintainable towards the future!

Sure! I used the stat ID here because my understanding is that using an AnalyticsEvent is more important when there are custom properties for the event. But it's no problem — I made that change in 3540bf2. (I also updated the other products onboarding event to use an AnalyticsEvent.)

@rachelmcr rachelmcr enabled auto-merge October 31, 2022 17:53
@rachelmcr rachelmcr merged commit e7bbafb into trunk Oct 31, 2022
@rachelmcr rachelmcr deleted the issue/7979-products-onboarding-analytics branch October 31, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: tracks Related to analytics, including Tracks Events. feature: products onboarding Related to onboarding new users to manage products status: feature-flagged Behind a feature flag. Milestone is not strongly held.

Projects

None yet

Milestone

11.1

Development

Successfully merging this pull request may close these issues.

Products Onboarding: Add banner analytics

4 participants

@rachelmcr @wpmobilebot @Ecarrion