Skip to content

Analytics Hub: Adds Report Card #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 23, 2022
Merged

Analytics Hub: Adds Report Card #8177

merged 13 commits into from
Nov 23, 2022
+147 −8

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Nov 21, 2022 •
edited
Loading

part of #8148

Why

This PR adds the Report Card UI that will be used on the Analytics Hub view

Note: Rotation & Accessibility will be handled in a different PR.

Screenshots

Light Dark
light dark

Testing instructions

  • Launch the app
  • Tap the "See More" button from the main dashboard
  • See the report cards with dummy data.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Nov 21, 2022
@Ecarrion Ecarrion added this to the 11.4 milestone Nov 21, 2022
@Ecarrion Ecarrion linked an issue Nov 21, 2022 that may be closed by this pull request
[Analytics Hub] Create reusable Analytics stats main body with info card component #8148
Closed
@rachelmcr rachelmcr self-assigned this Nov 22, 2022
rachelmcr
rachelmcr approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 I have some questions/suggestions below but nothing I'd consider blocking.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 23, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8177-6614415 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from issue/8148-adds-main-view to trunk November 23, 2022 13:22
@Ecarrion Ecarrion merged commit d9be157 into trunk Nov 23, 2022
@Ecarrion Ecarrion deleted the issue/8148-cards branch November 23, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Create reusable Analytics stats main body with info card component

4 participants

@Ecarrion @wpmobilebot @rachelmcr