Skip to content

[Mobile Payments] Rollback StripeTerminal to 2.7 pending fix for lldb po issue #8206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Mobile Payments] Rollback StripeTerminal to 2.7 pending fix for lldb po issue #8206

wants to merge 1 commit into from

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 24, 2022 •
edited
Loading

Closes: #

Description

When using po to inspect variables in lldb, developers found they faced various errors such as:

error: expression failed to parse:
error: virtual filesystem overlay file '/Users/bric/stripe/terminal/main/build/iphonesimulator/Build/Intermediates.noindex/ArchiveIntermediates/StripeTerminal/IntermediateBuildFilesPath/StripeTerminal.build/Release-iphonesimulator/StripeTerminal.build/all-product-headers.yaml' not found
error: virtual filesystem overlay file '/Users/bric/stripe/terminal/main/build/iphonesimulator/Build/Intermediates.noindex/ArchiveIntermediates/StripeTerminal/IntermediateBuildFilesPath/StripeTerminal.build/Release-iphonesimulator/StripeTerminal.build/all-product-headers.yaml' not found

error: couldn't IRGen expression. Please check the above error messages for possible root causes.

and

warning: Swift error in scratch context: error: failed to load module 'WooCommerce'
.
Shared Swift state for WooCommerce has developed fatal errors and is being discarded.
REPL definitions and persistent names/types will be lost.

error: expression failed to parse:
unknown error

I believe that the only way to fix this is with a new build of the StripeTerminal dependency: raising an issue on their repo to get it fixed.

Testing instructions

Check that you can still take an IPP payment and connect to reader successfully.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Nov 24, 2022
@joshheald joshheald added this to the 11.4 milestone Nov 24, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 24, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8206-488fa37 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@joshheald
Copy link
Contributor Author

joshheald commented Nov 24, 2022

Not required: Xcode 14.1 resolves the issue. Reported the bug to Stripe regardless

@joshheald joshheald closed this Nov 24, 2022
@joshheald joshheald deleted the task/revert-update-to-StripeTerminal-2.14 branch February 3, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

3 participants

@joshheald @wpmobilebot