Skip to content

Temporarily remove mistakenly merged entitlement #8212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

Temporarily remove mistakenly merged entitlement #8212

merged 1 commit into from
Nov 25, 2022

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 24, 2022

Description

I mistakenly merged #8172, which includes an entitlement not yet in our provisioning profiles. This will prevent the app from being built in Debug schemes, on physical test devices.

This PR temporarily removes the entitlement so the app can be built again.

The code which requires the entitlement is all behind a feature flag, which is toggled off by default, so this will have no impact on people continuing to work in other areas of the app.

Testing instructions

Run the app on a physical device
Ensure that the experimental toggle Tap to Pay on iPhone is off
Attempt to collect an in-person payment
Observe that you are able to collect a payment using a bluetooth reader.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Nov 24, 2022
@joshheald joshheald added this to the 11.4 milestone Nov 24, 2022
@joshheald joshheald marked this pull request as ready for review November 24, 2022 17:49
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 25, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8212-2a1b74f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamgabrielma iamgabrielma self-assigned this Nov 25, 2022
@iamgabrielma iamgabrielma self-requested a review November 25, 2022 04:28
iamgabrielma
iamgabrielma approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! 🚢

@iamgabrielma iamgabrielma merged commit 6d8fb05 into trunk Nov 25, 2022
@iamgabrielma iamgabrielma deleted the task/remove-tap-on-mobile-entitlement branch November 25, 2022 07:51
This was referenced Nov 25, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamgabrielma iamgabrielma iamgabrielma approved these changes

Assignees

@iamgabrielma iamgabrielma

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

4 participants

@joshheald @wpmobilebot @iamgabrielma