Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Dec 2, 2022

Description

The app's deployment target is iOS 15.0, so all those checks would always result true.

Testing instructions

Unless I made a mistake in removing a check, which should come up during code review, if CI is green we're good to merge.
Still, I run the app and clicked around a bit.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

The app's deployment target is iOS 15.0+
The app's deployment target is iOS 15.0+
The app's deployment target is iOS 15.0+
The app's deployment target is iOS 15.0+
The app's deployment target is iOS 15.0+
self
}
}
modifier(AutofocusTextModifier())
Copy link
Contributor Author

@mokagio mokagio Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly checked this still worked:

focused

@mokagio mokagio requested a review from crazytonyli December 2, 2022 10:09
@mokagio mokagio self-assigned this Dec 2, 2022
@mokagio mokagio added the type: technical debt Represents or solves tech debt of the project. label Dec 2, 2022
@mokagio mokagio added this to the 11.6 milestone Dec 2, 2022
@mokagio mokagio enabled auto-merge December 2, 2022 10:10
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8291-428395d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio merged commit 21bc222 into trunk Dec 5, 2022
@mokagio mokagio deleted the mokagio/remove-redundant-available-checks branch December 5, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants